Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 96 | 0 | 0 | 1622 |
Files
net/sf/oness/common/model/accounting/Money.java
| Error | Line |
|---|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
24
|
|
| Line has trailing spaces. |
26
|
|
| Line has trailing spaces. |
29
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
36
|
|
| First sentence should end with a period. |
38
|
|
| Line has trailing spaces. |
41
|
|
| First sentence should end with a period. |
49
|
|
| Line has trailing spaces. |
51
|
|
| Parameter amount should be final. |
55
|
|
| 'amount' hides a field. |
55
|
|
| Expected @param tag for 'amount'. |
55
|
|
| Parameter currency should be final. |
55
|
|
| 'currency' hides a field. |
55
|
|
| Expected @param tag for 'currency'. |
55
|
|
| First sentence should end with a period. |
60
|
|
| Line has trailing spaces. |
61
|
|
| Line has trailing spaces. |
63
|
|
| Parameter currency should be final. |
66
|
|
| 'currency' hides a field. |
66
|
|
| Expected @param tag for 'currency'. |
66
|
|
| Method 'getAmount' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Missing a Javadoc comment. |
71
|
|
| Method 'getCurrency' is not designed for extension - needs to be abstract, final or empty. |
75
|
|
| Missing a Javadoc comment. |
75
|
|
| Line has trailing spaces. |
80
|
|
| Expected an @return tag. |
86
|
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
| Parameter arg should be final. |
86
|
|
| Expected @param tag for 'arg'. |
86
|
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
86
|
|
| Line has trailing spaces. |
92
|
|
| Expected an @return tag. |
98
|
|
| Method 'subtract' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
| Parameter arg should be final. |
98
|
|
| Expected @param tag for 'arg'. |
98
|
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
98
|
|
| Line has trailing spaces. |
104
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
106
|
|
| Expected an @return tag. |
108
|
|
| Method 'negate' is not designed for extension - needs to be abstract, final or empty. |
108
|
|
| Method 'multiply' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
| Missing a Javadoc comment. |
112
|
|
| Parameter arg should be final. |
112
|
|
| Expected an @return tag. |
121
|
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
| Parameter arg should be final. |
121
|
|
| Expected @param tag for 'arg'. |
121
|
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
122
|
|
| Expected @throws tag for 'ClassCastException'. |
122
|
|
| Redundant throws: 'ClassCastException' is unchecked exception. |
122
|
|
| Line has trailing spaces. |
129
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
132
|
|
| Expected an @return tag. |
134
|
|
| Method 'greaterThan' is not designed for extension - needs to be abstract, final or empty. |
134
|
|
| Parameter arg should be final. |
134
|
|
| Expected @param tag for 'arg'. |
134
|
|
| Line has trailing spaces. |
139
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
142
|
|
| Expected an @return tag. |
144
|
|
| Method 'lessThan' is not designed for extension - needs to be abstract, final or empty. |
144
|
|
| Parameter arg should be final. |
144
|
|
| Expected @param tag for 'arg'. |
144
|
|
| Line has trailing spaces. |
149
|
|
| Parameter arg should be final. |
153
|
|
| Expected @param tag for 'arg'. |
153
|
|
| Redundant throws: 'IllegalArgumentException' is unchecked exception. |
153
|
|
| 'if' construct must use '{}'s. |
154
|
net/sf/oness/common/model/accounting/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/auditing/AbstractAuditableObject.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/auditing/AbstractAuditableObject.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Redundant import from the same package - net.sf.oness.common.model.auditing.Auditable. |
19
|
|
| First sentence should end with a period. |
22
|
|
| Line has trailing spaces. |
24
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
40
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter id should be final. |
44
|
|
| 'id' hides a field. |
44
|
|
| Method 'setCode' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Parameter code should be final. |
52
|
|
| 'code' hides a field. |
52
|
|
| Method 'getCode' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Method 'setTransactionTime' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
| Missing a Javadoc comment. |
63
|
|
| Parameter transactionTime should be final. |
63
|
|
| 'transactionTime' hides a field. |
63
|
|
| Method 'getTransactionTime' is not designed for extension - needs to be abstract, final or empty. |
70
|
|
| Method 'setCreatedBy' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Missing a Javadoc comment. |
74
|
|
| Parameter userName should be final. |
74
|
|
| Method 'getCreatedBy' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Method 'setDeletedBy' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Missing a Javadoc comment. |
85
|
|
| Parameter userName should be final. |
85
|
|
| Method 'getDeletedBy' is not designed for extension - needs to be abstract, final or empty. |
92
|
net/sf/oness/common/model/auditing/Auditable.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/auditing/Auditable.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
20
|
|
| Line has trailing spaces. |
22
|
|
| First sentence should end with a period. |
28
|
|
| Line has trailing spaces. |
30
|
|
| Expected an @return tag. |
33
|
|
| Redundant 'public' modifier. |
33
|
|
| Line has trailing spaces. |
36
|
|
| Redundant 'public' modifier. |
39
|
|
| Expected @param tag for 'id'. |
39
|
|
| Redundant 'public' modifier. |
45
|
|
| First sentence should end with a period. |
47
|
|
| Line has trailing spaces. |
49
|
|
| Redundant 'public' modifier. |
52
|
|
| Line has trailing spaces. |
55
|
|
| Redundant 'public' modifier. |
58
|
|
| Expected @param tag for 'transactionTime'. |
58
|
|
| First sentence should end with a period. |
60
|
|
| Line has trailing spaces. |
62
|
|
| Expected an @return tag. |
65
|
|
| Redundant 'public' modifier. |
65
|
|
| First sentence should end with a period. |
67
|
|
| Line has trailing spaces. |
69
|
|
| Redundant 'public' modifier. |
72
|
|
| Expected @param tag for 'userName'. |
72
|
|
| First sentence should end with a period. |
74
|
|
| Line has trailing spaces. |
76
|
|
| Redundant 'public' modifier. |
79
|
|
| First sentence should end with a period. |
81
|
|
| Line has trailing spaces. |
83
|
|
| Redundant 'public' modifier. |
86
|
|
| Expected @param tag for 'userName'. |
86
|
|
| First sentence should end with a period. |
88
|
|
| Line has trailing spaces. |
90
|
|
| Redundant 'public' modifier. |
93
|
|
| Line has trailing spaces. |
97
|
|
| Redundant 'public' modifier. |
100
|
net/sf/oness/common/model/auditing/AuditingUtils.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/auditing/AuditingUtils.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
23
|
|
| Line has trailing spaces. |
25
|
|
| Utility classes should not have a public or default constructor. |
29
|
|
| First sentence should end with a period. |
31
|
|
| Line has trailing spaces. |
33
|
|
| Expected an @return tag. |
38
|
|
| Parameter values should be final. |
38
|
|
| 'if' construct must use '{}'s. |
43
|
net/sf/oness/common/model/auditing/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/bo/AbstractBusinessObject.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/bo/AbstractBusinessObject.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
31
|
|
| Missing a Javadoc comment. |
38
|
|
| Line has trailing spaces. |
42
|
|
| Expected an @return tag. |
45
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Line has trailing spaces. |
51
|
|
| Method 'getCode' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Line is longer than 80 characters. |
59
|
|
| Line has trailing spaces. |
62
|
|
| Method 'getTransactionTime' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
| Line has trailing spaces. |
71
|
|
| Method 'getCreatedBy' is not designed for extension - needs to be abstract, final or empty. |
74
|
|
| Line has trailing spaces. |
80
|
|
| Method 'getDeletedBy' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| First sentence should end with a period. |
87
|
|
| Line has trailing spaces. |
89
|
|
| Line has trailing spaces. |
91
|
|
| Method 'getComments' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Method 'setComments' is not designed for extension - needs to be abstract, final or empty. |
98
|
|
| Missing a Javadoc comment. |
98
|
|
| Parameter comments should be final. |
98
|
|
| 'comments' hides a field. |
98
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
105
|
|
| Parameter o should be final. |
105
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
119
|
|
| Line has trailing spaces. |
126
|
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| Array brackets at illegal position. |
132
|
net/sf/oness/common/model/bo/AuditableBusinessObject.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/bo/AuditableBusinessObject.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
20
|
|
| Line has trailing spaces. |
22
|
net/sf/oness/common/model/bo/CollectionIgnoringEqualsBuilder.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/bo/CollectionIgnoringEqualsBuilder.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
31
|
|
| Line has trailing spaces. |
35
|
|
| Line has trailing spaces. |
37
|
|
| Missing a Javadoc comment. |
47
|
|
| Line is longer than 80 characters. |
69
|
|
| Line is longer than 80 characters. |
72
|
|
| Line is longer than 80 characters. |
74
|
|
| Line is longer than 80 characters. |
80
|
|
| Parameter lhs should be final. |
86
|
|
| Parameter rhs should be final. |
86
|
|
| Line is longer than 80 characters. |
91
|
|
| Line is longer than 80 characters. |
94
|
|
| Line is longer than 80 characters. |
96
|
|
| Line is longer than 80 characters. |
103
|
|
| Line is longer than 80 characters. |
110
|
|
| Parameter lhs should be final. |
110
|
|
| Parameter rhs should be final. |
110
|
|
| Parameter testTransients should be final. |
110
|
|
| Line is longer than 80 characters. |
115
|
|
| Line is longer than 80 characters. |
118
|
|
| Line is longer than 80 characters. |
120
|
|
| Line is longer than 80 characters. |
128
|
|
| Line is longer than 80 characters. |
139
|
|
| Parameter lhs should be final. |
139
|
|
| Parameter rhs should be final. |
139
|
|
| Parameter testTransients should be final. |
139
|
|
| Parameter reflectUpToClass should be final. |
139
|
|
| Line has trailing spaces. |
146
|
|
| Line has trailing spaces. |
148
|
|
| Line is longer than 80 characters. |
169
|
|
| Line is longer than 80 characters. |
171
|
|
| Line is longer than 80 characters. |
172
|
|
| Line is longer than 80 characters. |
174
|
|
| Line has trailing spaces. |
178
|
|
| Line is longer than 80 characters. |
180
|
|
| Line has trailing spaces. |
190
|
|
| Parameter lhs should be final. |
198
|
|
| Parameter rhs should be final. |
199
|
|
| Parameter clazz should be final. |
200
|
|
| Parameter builder should be final. |
201
|
|
| Parameter useTransients should be final. |
202
|
|
| Line is longer than 80 characters. |
215
|
|
| Method 'appendSuper' is not designed for extension - needs to be abstract, final or empty. |
230
|
|
| Parameter superEquals should be final. |
230
|
|
| Expression can be simplified. |
231
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
248
|
|
| Parameter lhs should be final. |
248
|
|
| Parameter rhs should be final. |
248
|
|
| Expression can be simplified. |
249
|
|
| Line has trailing spaces. |
255
|
|
| 'if' construct must use '{}'s. |
257
|
|
| 'if' construct must use '{}'s. |
258
|
|
| Line has trailing spaces. |
261
|
|
| Line has trailing spaces. |
278
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
321
|
|
| Parameter lhs should be final. |
321
|
|
| Parameter rhs should be final. |
321
|
|
| Expression can be simplified. |
322
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
336
|
|
| Parameter lhs should be final. |
336
|
|
| Parameter rhs should be final. |
336
|
|
| Expression can be simplified. |
337
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
351
|
|
| Parameter lhs should be final. |
351
|
|
| Parameter rhs should be final. |
351
|
|
| Expression can be simplified. |
352
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
366
|
|
| Parameter lhs should be final. |
366
|
|
| Parameter rhs should be final. |
366
|
|
| Expression can be simplified. |
367
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
381
|
|
| Parameter lhs should be final. |
381
|
|
| Parameter rhs should be final. |
381
|
|
| Expression can be simplified. |
382
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
402
|
|
| Parameter lhs should be final. |
402
|
|
| Parameter rhs should be final. |
402
|
|
| Expression can be simplified. |
403
|
|
| Line is longer than 80 characters. |
406
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
422
|
|
| Parameter lhs should be final. |
422
|
|
| Parameter rhs should be final. |
422
|
|
| Expression can be simplified. |
423
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
436
|
|
| Parameter lhs should be final. |
436
|
|
| Parameter rhs should be final. |
436
|
|
| Expression can be simplified. |
437
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
454
|
|
| Parameter lhs should be final. |
454
|
|
| Parameter rhs should be final. |
454
|
|
| Expression can be simplified. |
455
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
490
|
|
| Parameter lhs should be final. |
490
|
|
| Parameter rhs should be final. |
490
|
|
| Expression can be simplified. |
491
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
521
|
|
| Parameter lhs should be final. |
521
|
|
| Parameter rhs should be final. |
521
|
|
| Expression can be simplified. |
522
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
552
|
|
| Parameter lhs should be final. |
552
|
|
| Parameter rhs should be final. |
552
|
|
| Expression can be simplified. |
553
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
583
|
|
| Parameter lhs should be final. |
583
|
|
| Parameter rhs should be final. |
583
|
|
| Expression can be simplified. |
584
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
614
|
|
| Parameter lhs should be final. |
614
|
|
| Parameter rhs should be final. |
614
|
|
| Expression can be simplified. |
615
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
645
|
|
| Parameter lhs should be final. |
645
|
|
| Parameter rhs should be final. |
645
|
|
| Expression can be simplified. |
646
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
676
|
|
| Parameter lhs should be final. |
676
|
|
| Parameter rhs should be final. |
676
|
|
| Expression can be simplified. |
677
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
707
|
|
| Parameter lhs should be final. |
707
|
|
| Parameter rhs should be final. |
707
|
|
| Expression can be simplified. |
708
|
|
| Method 'isEquals' is not designed for extension - needs to be abstract, final or empty. |
734
|
net/sf/oness/common/model/bo/CollectionIgnoringHashCodeBuilder.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/bo/CollectionIgnoringHashCodeBuilder.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
29
|
|
| Line has trailing spaces. |
31
|
|
| Missing a Javadoc comment. |
40
|
|
| Line has trailing spaces. |
57
|
|
| '37' is a magic number. |
65
|
|
| '17' is a magic number. |
66
|
|
| Line has trailing spaces. |
73
|
|
| Line has trailing spaces. |
78
|
|
| Line has trailing spaces. |
82
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
87
|
|
| Parameter initialNonZeroOddNumber should be final. |
90
|
|
| Parameter multiplierNonZeroOddNumber should be final. |
91
|
|
| Line has trailing spaces. |
119
|
|
| Line has trailing spaces. |
124
|
|
| Line has trailing spaces. |
131
|
|
| Line has trailing spaces. |
136
|
|
| Line has trailing spaces. |
140
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
144
|
|
| Parameter object should be final. |
147
|
|
| '17' is a magic number. |
148
|
|
| '37' is a magic number. |
148
|
|
| Line has trailing spaces. |
155
|
|
| Line has trailing spaces. |
160
|
|
| Line has trailing spaces. |
167
|
|
| Line has trailing spaces. |
173
|
|
| Line has trailing spaces. |
177
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
183
|
|
| Line is longer than 80 characters. |
186
|
|
| Parameter object should be final. |
186
|
|
| Parameter testTransients should be final. |
186
|
|
| '17' is a magic number. |
187
|
|
| '37' is a magic number. |
187
|
|
| Line has trailing spaces. |
194
|
|
| Line has trailing spaces. |
201
|
|
| Line has trailing spaces. |
206
|
|
| Line has trailing spaces. |
210
|
|
| Line has trailing spaces. |
216
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
224
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
226
|
|
| Parameter initialNonZeroOddNumber should be final. |
229
|
|
| Parameter multiplierNonZeroOddNumber should be final. |
230
|
|
| Parameter object should be final. |
230
|
|
| Line has trailing spaces. |
239
|
|
| Line has trailing spaces. |
246
|
|
| Line has trailing spaces. |
252
|
|
| Line has trailing spaces. |
256
|
|
| Line has trailing spaces. |
262
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
272
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
274
|
|
| Parameter initialNonZeroOddNumber should be final. |
277
|
|
| Parameter multiplierNonZeroOddNumber should be final. |
278
|
|
| Parameter object should be final. |
278
|
|
| Parameter testTransients should be final. |
279
|
|
| Line has trailing spaces. |
288
|
|
| Line has trailing spaces. |
295
|
|
| Line has trailing spaces. |
301
|
|
| Line has trailing spaces. |
307
|
|
| Line has trailing spaces. |
313
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
326
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
328
|
|
| Parameter initialNonZeroOddNumber should be final. |
332
|
|
| Parameter multiplierNonZeroOddNumber should be final. |
333
|
|
| Parameter object should be final. |
333
|
|
| Parameter testTransients should be final. |
334
|
|
| Parameter reflectUpToClass should be final. |
334
|
|
| Line has trailing spaces. |
356
|
|
| Parameter object should be final. |
366
|
|
| Parameter clazz should be final. |
366
|
|
| Parameter builder should be final. |
367
|
|
| Parameter useTransients should be final. |
367
|
|
| Line is longer than 80 characters. |
381
|
|
| Line has trailing spaces. |
393
|
|
| Method 'appendSuper' is not designed for extension - needs to be abstract, final or empty. |
399
|
|
| Parameter superHashCode should be final. |
399
|
|
| Line has trailing spaces. |
411
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
416
|
|
| Parameter object should be final. |
416
|
|
| Expression can be simplified. |
429
|
|
| Line is longer than 80 characters. |
444
|
|
| Line has trailing spaces. |
484
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
489
|
|
| Parameter value should be final. |
489
|
|
| '32' is a magic number. |
490
|
|
| Line has trailing spaces. |
498
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
503
|
|
| Parameter value should be final. |
503
|
|
| Line has trailing spaces. |
512
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
517
|
|
| Parameter value should be final. |
517
|
|
| Line has trailing spaces. |
526
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
531
|
|
| Parameter value should be final. |
531
|
|
| Line has trailing spaces. |
540
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
545
|
|
| Parameter value should be final. |
545
|
|
| Line has trailing spaces. |
554
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
559
|
|
| Parameter value should be final. |
559
|
|
| Line has trailing spaces. |
567
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
572
|
|
| Parameter value should be final. |
572
|
|
| Line has trailing spaces. |
581
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
586
|
|
| Parameter value should be final. |
586
|
|
| Avoid inline conditionals. |
587
|
|
| Line has trailing spaces. |
595
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
600
|
|
| Parameter array should be final. |
600
|
|
| Line has trailing spaces. |
615
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
620
|
|
| Parameter array should be final. |
620
|
|
| Line has trailing spaces. |
635
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
640
|
|
| Parameter array should be final. |
640
|
|
| Line has trailing spaces. |
655
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
660
|
|
| Parameter array should be final. |
660
|
|
| Line has trailing spaces. |
675
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
680
|
|
| Parameter array should be final. |
680
|
|
| Line has trailing spaces. |
695
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
700
|
|
| Parameter array should be final. |
700
|
|
| Line has trailing spaces. |
715
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
720
|
|
| Parameter array should be final. |
720
|
|
| Line has trailing spaces. |
735
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
740
|
|
| Parameter array should be final. |
740
|
|
| Line has trailing spaces. |
755
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
760
|
|
| Parameter array should be final. |
760
|
|
| Line has trailing spaces. |
775
|
|
| Method 'toHashCode' is not designed for extension - needs to be abstract, final or empty. |
778
|
net/sf/oness/common/model/bo/CollectionIgnoringReflectionToStringBuilder.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/bo/CollectionIgnoringReflectionToStringBuilder.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
25
|
|
| Line has trailing spaces. |
27
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter object should be final. |
34
|
|
| Line has trailing spaces. |
40
|
|
| Line is longer than 80 characters. |
41
|
|
| Method 'accept' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Parameter field should be final. |
43
|
|
| 'if' construct must use '{}'s. |
44
|
net/sf/oness/common/model/bo/ExceptionSafeEqualsBuilder.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/bo/ExceptionSafeEqualsBuilder.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
29
|
|
| Line has trailing spaces. |
31
|
|
| Line has trailing spaces. |
33
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
55
|
|
| Parameter lhs should be final. |
55
|
|
| Parameter rhs should be final. |
55
|
|
| Missing a Javadoc comment. |
59
|
|
| Parameter lhs should be final. |
59
|
|
| Parameter rhs should be final. |
59
|
|
| Parameter testTransients should be final. |
60
|
|
| Missing a Javadoc comment. |
64
|
|
| Parameter lhs should be final. |
64
|
|
| Parameter rhs should be final. |
64
|
|
| Parameter testTransients should be final. |
65
|
|
| Parameter reflectUpToClass should be final. |
65
|
|
| Line is longer than 80 characters. |
95
|
|
| Line is longer than 80 characters. |
97
|
|
| Missing a Javadoc comment. |
116
|
|
| Parameter lhs should be final. |
116
|
|
| Parameter rhs should be final. |
116
|
|
| Parameter clazz should be final. |
116
|
|
| Parameter builder should be final. |
117
|
|
| Parameter useTransients should be final. |
117
|
|
| Line is longer than 80 characters. |
131
|
|
| Method 'appendSuper' is not designed for extension - needs to be abstract, final or empty. |
139
|
|
| Missing a Javadoc comment. |
139
|
|
| Parameter superEquals should be final. |
139
|
|
| Expression can be simplified. |
140
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
| Missing a Javadoc comment. |
149
|
|
| Parameter lhs should be final. |
149
|
|
| Parameter rhs should be final. |
149
|
|
| Expression can be simplified. |
150
|
|
| Line has trailing spaces. |
171
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
216
|
|
| Missing a Javadoc comment. |
216
|
|
| Parameter lhs should be final. |
216
|
|
| Parameter rhs should be final. |
216
|
|
| Expression can be simplified. |
217
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
224
|
|
| Missing a Javadoc comment. |
224
|
|
| Parameter lhs should be final. |
224
|
|
| Parameter rhs should be final. |
224
|
|
| Expression can be simplified. |
225
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
232
|
|
| Missing a Javadoc comment. |
232
|
|
| Parameter lhs should be final. |
232
|
|
| Parameter rhs should be final. |
232
|
|
| Expression can be simplified. |
233
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
240
|
|
| Missing a Javadoc comment. |
240
|
|
| Parameter lhs should be final. |
240
|
|
| Parameter rhs should be final. |
240
|
|
| Expression can be simplified. |
241
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
248
|
|
| Missing a Javadoc comment. |
248
|
|
| Parameter lhs should be final. |
248
|
|
| Parameter rhs should be final. |
248
|
|
| Expression can be simplified. |
249
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
256
|
|
| Missing a Javadoc comment. |
256
|
|
| Parameter lhs should be final. |
256
|
|
| Parameter rhs should be final. |
256
|
|
| Expression can be simplified. |
257
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
264
|
|
| Missing a Javadoc comment. |
264
|
|
| Parameter lhs should be final. |
264
|
|
| Parameter rhs should be final. |
264
|
|
| Expression can be simplified. |
265
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
271
|
|
| Missing a Javadoc comment. |
271
|
|
| Parameter lhs should be final. |
271
|
|
| Parameter rhs should be final. |
271
|
|
| Expression can be simplified. |
272
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
279
|
|
| Missing a Javadoc comment. |
279
|
|
| Parameter lhs should be final. |
279
|
|
| Parameter rhs should be final. |
279
|
|
| Expression can be simplified. |
280
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
305
|
|
| Missing a Javadoc comment. |
305
|
|
| Parameter lhs should be final. |
305
|
|
| Parameter rhs should be final. |
305
|
|
| Expression can be simplified. |
306
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
326
|
|
| Missing a Javadoc comment. |
326
|
|
| Parameter lhs should be final. |
326
|
|
| Parameter rhs should be final. |
326
|
|
| Expression can be simplified. |
327
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
347
|
|
| Missing a Javadoc comment. |
347
|
|
| Parameter lhs should be final. |
347
|
|
| Parameter rhs should be final. |
347
|
|
| Expression can be simplified. |
348
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
368
|
|
| Missing a Javadoc comment. |
368
|
|
| Parameter lhs should be final. |
368
|
|
| Parameter rhs should be final. |
368
|
|
| Expression can be simplified. |
369
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
389
|
|
| Missing a Javadoc comment. |
389
|
|
| Parameter lhs should be final. |
389
|
|
| Parameter rhs should be final. |
389
|
|
| Expression can be simplified. |
390
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
410
|
|
| Missing a Javadoc comment. |
410
|
|
| Parameter lhs should be final. |
410
|
|
| Parameter rhs should be final. |
410
|
|
| Expression can be simplified. |
411
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
431
|
|
| Missing a Javadoc comment. |
431
|
|
| Parameter lhs should be final. |
431
|
|
| Parameter rhs should be final. |
431
|
|
| Expression can be simplified. |
432
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
452
|
|
| Missing a Javadoc comment. |
452
|
|
| Parameter lhs should be final. |
452
|
|
| Parameter rhs should be final. |
452
|
|
| Expression can be simplified. |
453
|
|
| Method 'isEquals' is not designed for extension - needs to be abstract, final or empty. |
473
|
|
| Missing a Javadoc comment. |
473
|
net/sf/oness/common/model/bo/ExceptionSafeHashCodeBuilder.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/bo/ExceptionSafeHashCodeBuilder.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
30
|
|
| Line has trailing spaces. |
32
|
|
| Missing a Javadoc comment. |
41
|
|
| Line has trailing spaces. |
58
|
|
| '37' is a magic number. |
66
|
|
| '17' is a magic number. |
67
|
|
| Line has trailing spaces. |
74
|
|
| Line has trailing spaces. |
79
|
|
| Line has trailing spaces. |
83
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
88
|
|
| Parameter initialNonZeroOddNumber should be final. |
91
|
|
| Parameter multiplierNonZeroOddNumber should be final. |
92
|
|
| Line has trailing spaces. |
120
|
|
| Line has trailing spaces. |
125
|
|
| Line has trailing spaces. |
132
|
|
| Line has trailing spaces. |
137
|
|
| Line has trailing spaces. |
141
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
145
|
|
| Parameter object should be final. |
148
|
|
| '17' is a magic number. |
149
|
|
| '37' is a magic number. |
149
|
|
| Line has trailing spaces. |
156
|
|
| Line has trailing spaces. |
161
|
|
| Line has trailing spaces. |
168
|
|
| Line has trailing spaces. |
174
|
|
| Line has trailing spaces. |
178
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
184
|
|
| Line is longer than 80 characters. |
187
|
|
| Parameter object should be final. |
187
|
|
| Parameter testTransients should be final. |
187
|
|
| '17' is a magic number. |
188
|
|
| '37' is a magic number. |
188
|
|
| Line has trailing spaces. |
195
|
|
| Line has trailing spaces. |
202
|
|
| Line has trailing spaces. |
207
|
|
| Line has trailing spaces. |
211
|
|
| Line has trailing spaces. |
217
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
225
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
227
|
|
| Parameter initialNonZeroOddNumber should be final. |
230
|
|
| Parameter multiplierNonZeroOddNumber should be final. |
231
|
|
| Parameter object should be final. |
231
|
|
| Line has trailing spaces. |
240
|
|
| Line has trailing spaces. |
247
|
|
| Line has trailing spaces. |
253
|
|
| Line has trailing spaces. |
257
|
|
| Line has trailing spaces. |
263
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
273
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
275
|
|
| Parameter initialNonZeroOddNumber should be final. |
278
|
|
| Parameter multiplierNonZeroOddNumber should be final. |
279
|
|
| Parameter object should be final. |
279
|
|
| Parameter testTransients should be final. |
280
|
|
| Line has trailing spaces. |
289
|
|
| Line has trailing spaces. |
296
|
|
| Line has trailing spaces. |
302
|
|
| Line has trailing spaces. |
308
|
|
| Line has trailing spaces. |
314
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
327
|
|
| Unused @throws tag for 'IllegalArgumentException'. |
329
|
|
| Parameter initialNonZeroOddNumber should be final. |
333
|
|
| Parameter multiplierNonZeroOddNumber should be final. |
334
|
|
| Parameter object should be final. |
334
|
|
| Parameter testTransients should be final. |
335
|
|
| Parameter reflectUpToClass should be final. |
335
|
|
| Line has trailing spaces. |
357
|
|
| Parameter object should be final. |
367
|
|
| Parameter clazz should be final. |
367
|
|
| Parameter builder should be final. |
368
|
|
| Parameter useTransients should be final. |
368
|
|
| Line is longer than 80 characters. |
382
|
|
| Line has trailing spaces. |
394
|
|
| Method 'appendSuper' is not designed for extension - needs to be abstract, final or empty. |
400
|
|
| Parameter superHashCode should be final. |
400
|
|
| Line has trailing spaces. |
412
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
417
|
|
| Parameter object should be final. |
417
|
|
| Expression can be simplified. |
422
|
|
| Line is longer than 80 characters. |
437
|
|
| Line has trailing spaces. |
477
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
482
|
|
| Parameter value should be final. |
482
|
|
| '32' is a magic number. |
483
|
|
| Line has trailing spaces. |
491
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
496
|
|
| Parameter value should be final. |
496
|
|
| Line has trailing spaces. |
505
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
510
|
|
| Parameter value should be final. |
510
|
|
| Line has trailing spaces. |
519
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
524
|
|
| Parameter value should be final. |
524
|
|
| Line has trailing spaces. |
533
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
538
|
|
| Parameter value should be final. |
538
|
|
| Line has trailing spaces. |
547
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
552
|
|
| Parameter value should be final. |
552
|
|
| Line has trailing spaces. |
560
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
565
|
|
| Parameter value should be final. |
565
|
|
| Line has trailing spaces. |
574
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
579
|
|
| Parameter value should be final. |
579
|
|
| Avoid inline conditionals. |
580
|
|
| Line has trailing spaces. |
588
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
593
|
|
| Parameter array should be final. |
593
|
|
| Line has trailing spaces. |
608
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
613
|
|
| Parameter array should be final. |
613
|
|
| Line has trailing spaces. |
628
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
633
|
|
| Parameter array should be final. |
633
|
|
| Line has trailing spaces. |
648
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
653
|
|
| Parameter array should be final. |
653
|
|
| Line has trailing spaces. |
668
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
673
|
|
| Parameter array should be final. |
673
|
|
| Line has trailing spaces. |
688
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
693
|
|
| Parameter array should be final. |
693
|
|
| Line has trailing spaces. |
708
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
713
|
|
| Parameter array should be final. |
713
|
|
| Line has trailing spaces. |
728
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
733
|
|
| Parameter array should be final. |
733
|
|
| Line has trailing spaces. |
748
|
|
| Method 'append' is not designed for extension - needs to be abstract, final or empty. |
753
|
|
| Parameter array should be final. |
753
|
|
| Line has trailing spaces. |
768
|
|
| Method 'toHashCode' is not designed for extension - needs to be abstract, final or empty. |
771
|
net/sf/oness/common/model/bo/ExceptionSafeReflectionToStringBuilder.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/bo/ExceptionSafeReflectionToStringBuilder.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
23
|
|
| Line has trailing spaces. |
25
|
|
| Line has trailing spaces. |
27
|
|
| Line has trailing spaces. |
29
|
|
| Missing a Javadoc comment. |
36
|
|
| Parameter object should be final. |
36
|
|
| Line has trailing spaces. |
44
|
|
| Line is longer than 80 characters. |
45
|
|
| Method 'accept' is not designed for extension - needs to be abstract, final or empty. |
47
|
|
| Parameter field should be final. |
47
|
|
| 'if' construct must use '{}'s. |
53
|
net/sf/oness/common/model/bo/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/dao/AuditableDao.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/AuditableDao.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line does not match expected header line of ' * Licensed under the Apache License, Version 2.0 (the "License");'. |
4
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
22
|
|
| Line has trailing spaces. |
24
|
|
| Line has trailing spaces. |
33
|
|
| Line has trailing spaces. |
35
|
|
| Unused @throws tag for 'org.springframework.dao.DataRetrievalFailureException'. |
39
|
|
| Redundant 'public' modifier. |
42
|
|
| First sentence should end with a period. |
44
|
|
| Line has trailing spaces. |
46
|
|
| Redundant 'public' modifier. |
51
|
|
| Expected @param tag for 'value'. |
51
|
|
| First sentence should end with a period. |
53
|
|
| Line has trailing spaces. |
55
|
|
| Unused @throws tag for 'org.springframework.dao.OptimisticLockingFailureException'. |
59
|
|
| Redundant 'public' modifier. |
62
|
|
| Line has trailing spaces. |
66
|
|
| Unused @throws tag for 'org.springframework.dao.DataRetrievalFailureException'. |
70
|
|
| Redundant 'public' modifier. |
73
|
net/sf/oness/common/model/dao/AuditableDaoAdvisor.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/AuditableDaoAdvisor.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
27
|
|
| Line has trailing spaces. |
29
|
|
| Missing a Javadoc comment. |
36
|
|
| Line is longer than 80 characters. |
42
|
|
| Method 'invoke' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Parameter invocation should be final. |
44
|
|
| 'if' construct must use '{}'s. |
49
|
|
| 'if' construct must use '{}'s. |
54
|
|
| Line is longer than 80 characters. |
70
|
|
| Method 'matches' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
| Parameter m should be final. |
73
|
|
| Parameter targetClass should be final. |
73
|
net/sf/oness/common/model/dao/AuditingDao.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/AuditingDao.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
26
|
|
| Line has trailing spaces. |
28
|
|
| Unused @throws tag for 'org.springframework.dao.OptimisticLockingFailureException'. |
31
|
|
| Redundant 'public' modifier. |
34
|
net/sf/oness/common/model/dao/AuditingDaoHelper.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/AuditingDaoHelper.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line does not match expected header line of ' * Licensed under the Apache License, Version 2.0 (the "License");'. |
4
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Unused import - net.sf.oness.common.model.auditing.Auditable. |
22
|
|
| First sentence should end with a period. |
35
|
|
| Line has trailing spaces. |
37
|
|
| Utility classes should not have a public or default constructor. |
41
|
|
| Missing a Javadoc comment. |
43
|
|
| First sentence should end with a period. |
49
|
|
| Line has trailing spaces. |
51
|
|
| Line is longer than 80 characters. |
52
|
|
| Parameter dao should be final. |
54
|
|
| Parameter value should be final. |
55
|
|
| Line has trailing spaces. |
67
|
|
| Unused @throws tag for 'OptimisticLockingFailureException'. |
69
|
|
| Line has trailing spaces. |
71
|
|
| Line is longer than 80 characters. |
72
|
|
| Parameter dao should be final. |
74
|
|
| Expected @param tag for 'dao'. |
74
|
|
| Parameter value should be final. |
75
|
|
| Expected @param tag for 'value'. |
75
|
|
| 'if' construct must use '{}'s. |
80
|
|
| First sentence should end with a period. |
106
|
|
| Line has trailing spaces. |
108
|
|
| Unused @throws tag for 'org.springframework.dao.OptimisticLockingFailureException'. |
109
|
|
| Line is longer than 80 characters. |
111
|
|
| Parameter dao should be final. |
113
|
|
| Expected @param tag for 'dao'. |
113
|
|
| Parameter id should be final. |
113
|
|
| Expected @param tag for 'id'. |
113
|
|
| 'if' construct must use '{}'s. |
117
|
net/sf/oness/common/model/dao/Dao.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/Dao.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line does not match expected header line of ' * Licensed under the Apache License, Version 2.0 (the "License");'. |
4
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
18
|
|
| Line has trailing spaces. |
20
|
net/sf/oness/common/model/dao/FinderDao.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/FinderDao.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
24
|
|
| Line has trailing spaces. |
26
|
|
| Line has trailing spaces. |
35
|
|
| Redundant 'public' modifier. |
40
|
|
| Line has trailing spaces. |
46
|
|
| Expected an @return tag. |
55
|
|
| Redundant 'public' modifier. |
55
|
|
| First sentence should end with a period. |
58
|
|
| Line has trailing spaces. |
60
|
|
| Redundant 'public' modifier. |
63
|
net/sf/oness/common/model/dao/hibernate/HibernateDao.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/hibernate/HibernateDao.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
45
|
|
| Line has trailing spaces. |
47
|
|
| Missing a Javadoc comment. |
53
|
|
| Line is longer than 80 characters. |
55
|
|
| Missing a Javadoc comment. |
55
|
|
| Missing a Javadoc comment. |
57
|
|
| First sentence should end with a period. |
59
|
|
| Line has trailing spaces. |
61
|
|
| Parameter theClass should be final. |
65
|
|
| 'theClass' hides a field. |
65
|
|
| Expected @param tag for 'theClass'. |
65
|
|
| First sentence should end with a period. |
69
|
|
| Line has trailing spaces. |
71
|
|
| Parameter className should be final. |
76
|
|
| Expected @param tag for 'className'. |
76
|
|
| Expected @throws tag for 'ClassNotFoundException'. |
76
|
|
| Line has trailing spaces. |
83
|
|
| Expected an @return tag. |
89
|
|
| Method 'load' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
| Parameter id should be final. |
89
|
|
| Line is longer than 80 characters. |
95
|
|
| Method 'findById' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
| Parameter id should be final. |
97
|
|
| Line is longer than 80 characters. |
102
|
|
| Method 'findById' is not designed for extension - needs to be abstract, final or empty. |
104
|
|
| Parameter ids should be final. |
104
|
|
| Line is longer than 80 characters. |
109
|
|
| Method 'findWithDetails' is not designed for extension - needs to be abstract, final or empty. |
111
|
|
| Parameter id should be final. |
111
|
|
| Line has trailing spaces. |
120
|
|
| Parameter session should be final. |
133
|
|
| 'if' construct must use '{}'s. |
149
|
|
| Line is longer than 80 characters. |
154
|
|
| Line is longer than 80 characters. |
161
|
|
| Line is longer than 80 characters. |
162
|
|
| First sentence should end with a period. |
181
|
|
| Line has trailing spaces. |
183
|
|
| Expected an @return tag. |
188
|
|
| Parameter session should be final. |
192
|
|
| Line is longer than 80 characters. |
210
|
|
| Method 'create' is not designed for extension - needs to be abstract, final or empty. |
212
|
|
| Line is longer than 80 characters. |
219
|
|
| Method 'update' is not designed for extension - needs to be abstract, final or empty. |
221
|
|
| Parameter bo should be final. |
221
|
|
| Line is longer than 80 characters. |
238
|
|
| Method 'find' is not designed for extension - needs to be abstract, final or empty. |
241
|
|
| Parameter bo should be final. |
241
|
|
| Parameter firstElement should be final. |
241
|
|
| Parameter maxElements should be final. |
242
|
|
| Line has trailing spaces. |
252
|
|
| Line has trailing spaces. |
254
|
|
| Expected an @return tag. |
263
|
|
| Parameter session should be final. |
268
|
|
| 'if' construct must use '{}'s. |
275
|
|
| 'if' construct must use '{}'s. |
288
|
|
| 'if' construct must use '{}'s. |
292
|
|
| 'if' construct must use '{}'s. |
297
|
|
| Line is longer than 80 characters. |
304
|
|
| Line is longer than 80 characters. |
305
|
|
| Array brackets at illegal position. |
308
|
|
| 'if' construct must use '{}'s. |
309
|
|
| 'if' construct must use '{}'s. |
310
|
|
| 'else' construct must use '{}'s. |
313
|
|
| 'if' construct must use '{}'s. |
316
|
|
| 'if' construct must use '{}'s. |
317
|
|
| 'else' construct must use '{}'s. |
320
|
|
| '}' should be on the same line. |
323
|
|
| 'else' construct must use '{}'s. |
325
|
|
| First sentence should end with a period. |
342
|
|
| Line has trailing spaces. |
344
|
|
| Line is longer than 80 characters. |
346
|
|
| Method 'delete' is not designed for extension - needs to be abstract, final or empty. |
348
|
|
| Parameter id should be final. |
348
|
|
| First sentence should end with a period. |
352
|
|
| Line has trailing spaces. |
354
|
|
| Method 'findAll' is not designed for extension - needs to be abstract, final or empty. |
357
|
|
| Line has trailing spaces. |
365
|
|
| Line has trailing spaces. |
369
|
|
| Method 'filterNotDeleted' is not designed for extension - needs to be abstract, final or empty. |
372
|
|
| Parameter collection should be final. |
372
|
net/sf/oness/common/model/dao/hibernate/HibernateDaoSupport.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/hibernate/HibernateDaoSupport.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
37
|
|
| Line has trailing spaces. |
51
|
|
| Method 'loadAndClone' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Parameter theClass should be final. |
59
|
|
| Parameter id should be final. |
59
|
|
| First sentence should end with a period. |
78
|
|
| Line has trailing spaces. |
80
|
|
| Expected an @return tag. |
93
|
|
| Method 'findByProperty' is not designed for extension - needs to be abstract, final or empty. |
93
|
|
| First sentence should end with a period. |
101
|
|
| Line has trailing spaces. |
103
|
|
| Expected an @return tag. |
116
|
|
| Method 'findByPropertyContent' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
| First sentence should end with a period. |
125
|
|
| Line has trailing spaces. |
128
|
|
| Expected an @return tag. |
141
|
|
| Parameter session should be final. |
147
|
|
| First sentence should end with a period. |
156
|
|
| Line has trailing spaces. |
159
|
|
| Expected an @return tag. |
172
|
|
| Parameter session should be final. |
178
|
|
| Line has trailing spaces. |
193
|
|
| Line has trailing spaces. |
199
|
|
| Method 'filter' is not designed for extension - needs to be abstract, final or empty. |
202
|
|
| Parameter collection should be final. |
202
|
|
| Parameter filter should be final. |
202
|
|
| Line has trailing spaces. |
218
|
|
| Parameter session should be final. |
230
|
net/sf/oness/common/model/dao/hibernate/HibernateProperties.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/dao/hibernate/HibernateProperties.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
21
|
|
| Line has trailing spaces. |
23
|
|
| Line has trailing spaces. |
24
|
|
| First sentence should end with a period. |
30
|
|
| Line has trailing spaces. |
32
|
|
| Parameter properties should be final. |
35
|
|
| Expected @param tag for 'properties'. |
35
|
|
| Method 'setHibernateDialect' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Missing a Javadoc comment. |
44
|
|
| Parameter hibernateDialect should be final. |
44
|
net/sf/oness/common/model/dao/hibernate/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/dao/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/exceptions/ExistingInstanceException.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
20
|
|
| Line has trailing spaces. |
23
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter object should be final. |
39
|
|
| 'object' hides a field. |
39
|
|
| Expected @param tag for 'object'. |
39
|
|
| Parameter className should be final. |
40
|
|
| 'className' hides a field. |
40
|
|
| Parameter existingInstances should be final. |
41
|
|
| 'existingInstances' hides a field. |
41
|
|
| Expected @param tag for 'existingInstances'. |
41
|
|
| Method 'getObject' is not designed for extension - needs to be abstract, final or empty. |
48
|
|
| Missing a Javadoc comment. |
48
|
|
| Method 'getClassName' is not designed for extension - needs to be abstract, final or empty. |
52
|
|
| Missing a Javadoc comment. |
52
|
|
| Method 'getExistingInstances' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Missing a Javadoc comment. |
56
|
net/sf/oness/common/model/exceptions/ModelException.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
20
|
|
| Missing a Javadoc comment. |
26
|
|
| Missing a Javadoc comment. |
29
|
|
| Parameter message should be final. |
29
|
net/sf/oness/common/model/exceptions/NonContinuousDataException.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
net/sf/oness/common/model/exceptions/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/security/SecurityHelper.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/security/SecurityHelper.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
22
|
|
| Line has trailing spaces. |
24
|
|
| Utility classes should not have a public or default constructor. |
28
|
|
| First sentence should end with a period. |
30
|
|
| Line has trailing spaces. |
32
|
net/sf/oness/common/model/security/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/temporal/Date.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/temporal/Date.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
39
|
|
| Line has trailing spaces. |
42
|
|
| Missing a Javadoc comment. |
48
|
|
| Name 'formatter' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
48
|
|
| First sentence should end with a period. |
51
|
|
| '1000' is a magic number. |
54
|
|
| First sentence should end with a period. |
57
|
|
| '9999' is a magic number. |
60
|
|
| '31' is a magic number. |
60
|
|
| '23' is a magic number. |
61
|
|
| '59' is a magic number. |
61
|
|
| '59' is a magic number. |
61
|
|
| Missing a Javadoc comment. |
63
|
|
| 'static' modifier out of order with the JLS suggestions. |
63
|
|
| Missing a Javadoc comment. |
65
|
|
| First sentence should end with a period. |
67
|
|
| Variable 'calendar' must be private and have accessor methods. |
70
|
|
| First sentence should end with a period. |
78
|
|
| Line has trailing spaces. |
80
|
|
| Line is longer than 80 characters. |
88
|
|
| Parameter year should be final. |
88
|
|
| Expected @param tag for 'year'. |
88
|
|
| Parameter month should be final. |
88
|
|
| Expected @param tag for 'month'. |
88
|
|
| Parameter day should be final. |
88
|
|
| Expected @param tag for 'day'. |
88
|
|
| Parameter hour should be final. |
88
|
|
| Expected @param tag for 'hour'. |
88
|
|
| Parameter minute should be final. |
88
|
|
| Expected @param tag for 'minute'. |
88
|
|
| Parameter second should be final. |
88
|
|
| Expected @param tag for 'second'. |
88
|
|
| Line is longer than 80 characters. |
89
|
|
| First sentence should end with a period. |
93
|
|
| Line has trailing spaces. |
95
|
|
| Parameter year should be final. |
100
|
|
| Expected @param tag for 'year'. |
100
|
|
| Parameter month should be final. |
100
|
|
| Expected @param tag for 'month'. |
100
|
|
| Parameter day should be final. |
100
|
|
| Expected @param tag for 'day'. |
100
|
|
| Line has trailing spaces. |
109
|
|
| Parameter calendar should be final. |
113
|
|
| 'calendar' hides a field. |
113
|
|
| Expected @param tag for 'calendar'. |
113
|
|
| Parameter truncateToField should be final. |
113
|
|
| 'truncateToField' hides a field. |
113
|
|
| Expected @param tag for 'truncateToField'. |
113
|
|
| Line has trailing spaces. |
124
|
|
| Parameter calendar should be final. |
127
|
|
| 'calendar' hides a field. |
127
|
|
| Expected @param tag for 'calendar'. |
127
|
|
| Expected an @return tag. |
135
|
|
| Unclosed HTML tag found: <code>Calendar<code> wrapped by this object. |
141
|
|
| Method 'getCalendar' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
| Unclosed HTML tag found: <code>Calendar<code> wrapped by this object. |
150
|
|
| Method 'setCalendar' is not designed for extension - needs to be abstract, final or empty. |
154
|
|
| Parameter calendar should be final. |
154
|
|
| 'calendar' hides a field. |
154
|
|
| Expected @param tag for 'calendar'. |
154
|
|
| Method 'after' is not designed for extension - needs to be abstract, final or empty. |
163
|
|
| Parameter when should be final. |
163
|
|
| Method 'before' is not designed for extension - needs to be abstract, final or empty. |
172
|
|
| Parameter when should be final. |
172
|
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
181
|
|
| Parameter arg should be final. |
181
|
|
| Unclosed HTML tag found: <code>java.util.Date<code> object. |
187
|
|
| Method 'getTime' is not designed for extension - needs to be abstract, final or empty. |
191
|
|
| Method 'addDays' is not designed for extension - needs to be abstract, final or empty. |
195
|
|
| Missing a Javadoc comment. |
195
|
|
| Parameter arg should be final. |
195
|
|
| Method 'addYears' is not designed for extension - needs to be abstract, final or empty. |
199
|
|
| Missing a Javadoc comment. |
199
|
|
| Parameter arg should be final. |
199
|
|
| Method 'getYear' is not designed for extension - needs to be abstract, final or empty. |
203
|
|
| Missing a Javadoc comment. |
203
|
|
| Method 'getMonth' is not designed for extension - needs to be abstract, final or empty. |
207
|
|
| Missing a Javadoc comment. |
207
|
|
| Method 'getDayOfMonth' is not designed for extension - needs to be abstract, final or empty. |
211
|
|
| Missing a Javadoc comment. |
211
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
215
|
|
| Missing a Javadoc comment. |
215
|
|
| 'if' construct must use '{}'s. |
216
|
|
| 'if' construct must use '{}'s. |
218
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
226
|
|
| Parameter o should be final. |
226
|
|
| Method 'hashCode' is not designed for extension - needs to be abstract, final or empty. |
237
|
|
| '19' is a magic number. |
238
|
|
| '41' is a magic number. |
238
|
|
| Line has trailing spaces. |
240
|
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
244
|
net/sf/oness/common/model/temporal/DateRange.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/temporal/DateRange.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
23
|
|
| Line has trailing spaces. |
25
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Name 'EMPTY' must match pattern '^[a-z][a-zA-Z0-9]*$'. |
33
|
|
| Variable 'EMPTY' must be private and have accessor methods. |
33
|
|
| '1980' is a magic number. |
33
|
|
| '1980' is a magic number. |
34
|
|
| Missing a Javadoc comment. |
37
|
|
| First sentence should end with a period. |
40
|
|
| Line has trailing spaces. |
42
|
|
| Parameter start should be final. |
48
|
|
| 'start' hides a field. |
48
|
|
| Parameter end should be final. |
48
|
|
| 'end' hides a field. |
48
|
|
| First sentence should end with a period. |
53
|
|
| Line has trailing spaces. |
55
|
|
| Method 'setStart' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Parameter start should be final. |
59
|
|
| 'start' hides a field. |
59
|
|
| Method 'getStart' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
| Missing a Javadoc comment. |
63
|
|
| First sentence should end with a period. |
67
|
|
| Line has trailing spaces. |
69
|
|
| Method 'setEnd' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
| Parameter end should be final. |
73
|
|
| 'end' hides a field. |
73
|
|
| Method 'getEnd' is not designed for extension - needs to be abstract, final or empty. |
77
|
|
| Missing a Javadoc comment. |
77
|
|
| Method 'isEmpty' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Missing a Javadoc comment. |
81
|
|
| Method 'isOpen' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Missing a Javadoc comment. |
85
|
|
| Method 'includes' is not designed for extension - needs to be abstract, final or empty. |
90
|
|
| Missing a Javadoc comment. |
90
|
|
| Parameter arg should be final. |
90
|
|
| Method 'endNow' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Missing a Javadoc comment. |
94
|
|
| Missing a Javadoc comment. |
98
|
|
| Parameter end should be final. |
98
|
|
| Missing a Javadoc comment. |
102
|
|
| Parameter start should be final. |
102
|
|
| Missing a Javadoc comment. |
106
|
|
| Missing a Javadoc comment. |
110
|
|
| Method 'overlaps' is not designed for extension - needs to be abstract, final or empty. |
115
|
|
| Missing a Javadoc comment. |
115
|
|
| Parameter arg should be final. |
115
|
|
| Method 'includes' is not designed for extension - needs to be abstract, final or empty. |
120
|
|
| Missing a Javadoc comment. |
120
|
|
| Parameter arg should be final. |
120
|
|
| Method 'gap' is not designed for extension - needs to be abstract, final or empty. |
124
|
|
| Missing a Javadoc comment. |
124
|
|
| Parameter arg should be final. |
124
|
|
| 'if' construct must use '{}'s. |
125
|
|
| 'start' hides a field. |
135
|
|
| 'end' hides a field. |
136
|
|
| Method 'compareTo' is not designed for extension - needs to be abstract, final or empty. |
142
|
|
| Missing a Javadoc comment. |
142
|
|
| Parameter arg should be final. |
142
|
|
| 'if' construct must use '{}'s. |
144
|
|
| Method 'abuts' is not designed for extension - needs to be abstract, final or empty. |
149
|
|
| Missing a Javadoc comment. |
149
|
|
| Parameter arg should be final. |
149
|
|
| Method 'partitionedBy' is not designed for extension - needs to be abstract, final or empty. |
153
|
|
| Missing a Javadoc comment. |
153
|
|
| Parameter args should be final. |
153
|
|
| 'if' construct must use '{}'s. |
154
|
|
| Missing a Javadoc comment. |
159
|
|
| Parameter args should be final. |
159
|
|
| 'if' construct must use '{}'s. |
161
|
|
| Line is longer than 80 characters. |
163
|
|
| Missing a Javadoc comment. |
166
|
|
| Parameter args should be final. |
166
|
|
| 'if' construct must use '{}'s. |
169
|
|
| Line has trailing spaces. |
177
|
|
| Method 'lengthInDays' is not designed for extension - needs to be abstract, final or empty. |
182
|
|
| 'if' construct must use '{}'s. |
183
|
|
| 'start' hides a field. |
185
|
|
| 'end' hides a field. |
186
|
|
| Line has trailing spaces. |
202
|
|
| Method 'lengthInMinutes' is not designed for extension - needs to be abstract, final or empty. |
207
|
|
| Line has trailing spaces. |
214
|
|
| Parameter field should be final. |
220
|
|
| 'if' construct must use '{}'s. |
221
|
|
| 'if' construct must use '{}'s. |
226
|
|
| '1000' is a magic number. |
229
|
|
| 'if' construct must use '{}'s. |
230
|
|
| '60' is a magic number. |
233
|
|
| 'if' construct must use '{}'s. |
234
|
|
| '60' is a magic number. |
237
|
|
| 'if' construct must use '{}'s. |
238
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
244
|
|
| Missing a Javadoc comment. |
244
|
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
251
|
|
| Avoid inline conditionals. |
252
|
|
| Avoid inline conditionals. |
253
|
net/sf/oness/common/model/temporal/TemporalValue.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
18
|
|
| Line has trailing spaces. |
20
|
|
| Line has trailing spaces. |
27
|
|
| Redundant 'public' modifier. |
30
|
|
| Expected @param tag for 'validTime'. |
30
|
|
| First sentence should end with a period. |
32
|
|
| Expected an @return tag. |
36
|
|
| Redundant 'public' modifier. |
36
|
net/sf/oness/common/model/temporal/TemporalValueUtil.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Unused import - java.util.ArrayList. |
18
|
|
| Unused import - java.util.Calendar. |
19
|
|
| Unused import - java.util.Collection. |
20
|
|
| Unused import - java.util.Collections. |
21
|
|
| Unused import - java.util.Comparator. |
22
|
|
| Unused import - java.util.Iterator. |
23
|
|
| Unused import - org.apache.commons.beanutils.BeanComparator. |
25
|
|
| Missing a Javadoc comment. |
33
|
|
| Line is longer than 80 characters. |
49
|
|
| Line is longer than 80 characters. |
63
|
|
| Line is longer than 80 characters. |
101
|
net/sf/oness/common/model/temporal/hibernate/DateRangeType.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/temporal/hibernate/DateRangeType.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
39
|
|
| Missing a Javadoc comment. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| '{' is followed by whitespace. |
47
|
|
| Missing a Javadoc comment. |
49
|
|
| 'if' construct must use '{}'s. |
56
|
|
| Method 'getPropertyNames' is not designed for extension - needs to be abstract, final or empty. |
64
|
|
| Method 'getPropertyTypes' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| First sentence should end with a period. |
75
|
|
| Line has trailing spaces. |
82
|
|
| Line is longer than 80 characters. |
83
|
|
| Method 'getPropertyValue' is not designed for extension - needs to be abstract, final or empty. |
86
|
|
| Parameter component should be final. |
86
|
|
| Parameter property should be final. |
86
|
|
| 'if' construct must use '{}'s. |
89
|
|
| 'if' construct must use '{}'s. |
92
|
|
| Avoid inline conditionals. |
93
|
|
| 'else' construct must use '{}'s. |
94
|
|
| Avoid inline conditionals. |
95
|
|
| First sentence should end with a period. |
98
|
|
| Line has trailing spaces. |
105
|
|
| Line is longer than 80 characters. |
106
|
|
| Method 'setPropertyValue' is not designed for extension - needs to be abstract, final or empty. |
109
|
|
| Parameter component should be final. |
109
|
|
| Parameter property should be final. |
109
|
|
| Parameter value should be final. |
109
|
|
| Avoid inline conditionals. |
113
|
|
| Avoid inline conditionals. |
115
|
|
| Method 'returnedClass' is not designed for extension - needs to be abstract, final or empty. |
122
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
| Parameter x should be final. |
130
|
|
| Parameter y should be final. |
130
|
|
| 'if' construct must use '{}'s. |
133
|
|
| 'if' construct must use '{}'s. |
135
|
|
| Method 'nullSafeGet' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
| Parameter rs should be final. |
145
|
|
| Parameter names should be final. |
145
|
|
| Parameter session should be final. |
146
|
|
| Parameter owner should be final. |
146
|
|
| Line is longer than 80 characters. |
159
|
|
| Method 'nullSafeSet' is not designed for extension - needs to be abstract, final or empty. |
162
|
|
| Parameter st should be final. |
162
|
|
| Parameter value should be final. |
162
|
|
| Parameter index should be final. |
162
|
|
| Line is longer than 80 characters. |
163
|
|
| Parameter session should be final. |
163
|
|
| Method 'deepCopy' is not designed for extension - needs to be abstract, final or empty. |
176
|
|
| Parameter value should be final. |
176
|
|
| 'if' construct must use '{}'s. |
177
|
|
| Method 'isMutable' is not designed for extension - needs to be abstract, final or empty. |
185
|
|
| First sentence should end with a period. |
189
|
|
| Line has trailing spaces. |
191
|
|
| Method 'disassemble' is not designed for extension - needs to be abstract, final or empty. |
196
|
|
| Parameter value should be final. |
196
|
|
| Parameter session should be final. |
196
|
|
| First sentence should end with a period. |
201
|
|
| Line has trailing spaces. |
203
|
|
| Method 'assemble' is not designed for extension - needs to be abstract, final or empty. |
208
|
|
| Parameter cached should be final. |
208
|
|
| Parameter session should be final. |
208
|
|
| Parameter owner should be final. |
209
|
net/sf/oness/common/model/temporal/hibernate/DateType.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
31
|
|
| Line has trailing spaces. |
33
|
|
| Missing a Javadoc comment. |
39
|
|
| '{' is followed by whitespace. |
39
|
|
| Method 'sqlTypes' is not designed for extension - needs to be abstract, final or empty. |
44
|
|
| Method 'returnedClass' is not designed for extension - needs to be abstract, final or empty. |
51
|
|
| Method 'equals' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Parameter x should be final. |
58
|
|
| Parameter y should be final. |
58
|
|
| 'if' construct must use '{}'s. |
59
|
|
| 'if' construct must use '{}'s. |
61
|
|
| Line is longer than 80 characters. |
67
|
|
| Method 'nullSafeGet' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
| Parameter rs should be final. |
69
|
|
| Parameter names should be final. |
69
|
|
| Parameter owner should be final. |
69
|
|
| 'if' construct must use '{}'s. |
73
|
|
| Avoid inline conditionals. |
77
|
|
| Line is longer than 80 characters. |
81
|
|
| Method 'nullSafeSet' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| Parameter st should be final. |
83
|
|
| Parameter value should be final. |
83
|
|
| Parameter index should be final. |
83
|
|
| Avoid inline conditionals. |
85
|
|
| Method 'deepCopy' is not designed for extension - needs to be abstract, final or empty. |
92
|
|
| Parameter value should be final. |
92
|
|
| 'if' construct must use '{}'s. |
93
|
|
| Method 'isMutable' is not designed for extension - needs to be abstract, final or empty. |
101
|
net/sf/oness/common/model/temporal/hibernate/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/temporal/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/testing/SpringApplicationContext.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/testing/SpringApplicationContext.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
26
|
|
| Line has trailing spaces. |
28
|
|
| Line is longer than 80 characters. |
29
|
|
| Line is longer than 80 characters. |
32
|
|
| Line has trailing spaces. |
38
|
|
| Utility classes should not have a public or default constructor. |
42
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
48
|
|
| Missing a Javadoc comment. |
55
|
|
| Parameter fileNames should be final. |
55
|
|
| 'fileNames' hides a field. |
55
|
|
| First sentence should end with a period. |
59
|
|
| Line has trailing spaces. |
61
|
|
| Expected an @return tag. |
64
|
|
| First sentence should end with a period. |
68
|
|
| Line has trailing spaces. |
70
|
|
| Expected an @return tag. |
74
|
|
| Parameter name should be final. |
74
|
|
| Expected @param tag for 'name'. |
74
|
net/sf/oness/common/model/testing/SpringDatabaseExport.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/testing/SpringDatabaseExport.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line does not match expected header line of ' * Licensed under the Apache License, Version 2.0 (the "License");'. |
4
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
32
|
|
| Line has trailing spaces. |
37
|
|
| Line has trailing spaces. |
41
|
|
| Utility classes should not have a public or default constructor. |
45
|
|
| Missing a Javadoc comment. |
47
|
|
| Missing a Javadoc comment. |
49
|
|
| Missing a Javadoc comment. |
51
|
|
| Parameter args should be final. |
51
|
net/sf/oness/common/model/testing/SpringDatabaseTestCase.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/testing/SpringDatabaseTestCase.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line does not match expected header line of ' * Licensed under the Apache License, Version 2.0 (the "License");'. |
4
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
31
|
|
| Line has trailing spaces. |
35
|
|
| Missing a Javadoc comment. |
41
|
|
| '{' is followed by whitespace. |
41
|
|
| Missing a Javadoc comment. |
44
|
|
| Missing a Javadoc comment. |
46
|
|
| Missing a Javadoc comment. |
50
|
|
| Parameter name should be final. |
50
|
|
| First sentence should end with a period. |
54
|
|
| Line has trailing spaces. |
57
|
|
| Method 'getConnection' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
| Line has trailing spaces. |
69
|
|
| Method 'getDataSet' is not designed for extension - needs to be abstract, final or empty. |
72
|
|
| 'if' construct must use '{}'s. |
77
|
|
| 'if' construct must use '{}'s. |
83
|
|
| 'if' construct must use '{}'s. |
87
|
|
| 'if' construct must use '{}'s. |
89
|
net/sf/oness/common/model/testing/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/to/AuditableTransferObject.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/to/AuditableTransferObject.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| First sentence should end with a period. |
20
|
|
| Line has trailing spaces. |
22
|
|
| Missing a Javadoc comment. |
28
|
|
| First sentence should end with a period. |
30
|
|
| Line has trailing spaces. |
32
|
|
| Method 'getComments' is not designed for extension - needs to be abstract, final or empty. |
35
|
|
| Method 'setComments' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Missing a Javadoc comment. |
39
|
|
| Parameter comments should be final. |
39
|
|
| 'comments' hides a field. |
39
|
net/sf/oness/common/model/to/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/util/CollectionCloneConverter.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/util/CollectionCloneConverter.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
22
|
|
| Line has trailing spaces. |
24
|
|
| Method 'convert' is not designed for extension - needs to be abstract, final or empty. |
34
|
|
| Parameter type should be final. |
34
|
|
| Parameter value should be final. |
34
|
net/sf/oness/common/model/util/CollectionUtils.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/util/CollectionUtils.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
30
|
|
| Line has trailing spaces. |
32
|
|
| Utility classes should not have a public or default constructor. |
36
|
|
| Line has trailing spaces. |
40
|
|
| Expected an @return tag. |
45
|
|
| Parameter set should be final. |
45
|
|
| Expected @param tag for 'set'. |
45
|
|
| Parameter object should be final. |
45
|
|
| Expected @param tag for 'object'. |
45
|
|
| Line has trailing spaces. |
52
|
|
| Expected an @return tag. |
57
|
|
| Parameter list should be final. |
57
|
|
| Expected @param tag for 'list'. |
57
|
|
| Parameter object should be final. |
57
|
|
| Expected @param tag for 'object'. |
57
|
|
| Line has trailing spaces. |
64
|
|
| Expected an @return tag. |
68
|
|
| Parameter object should be final. |
68
|
|
| Expected @param tag for 'object'. |
68
|
|
| Line has trailing spaces. |
74
|
|
| Expected an @return tag. |
78
|
|
| Parameter object should be final. |
78
|
|
| Expected @param tag for 'object'. |
78
|
|
| Missing a Javadoc comment. |
82
|
|
| Parameter theClass should be final. |
82
|
|
| Missing a Javadoc comment. |
86
|
|
| Parameter theClass should be final. |
86
|
|
| Line has trailing spaces. |
93
|
|
| Expected an @return tag. |
97
|
|
| Parameter collection should be final. |
97
|
|
| Expected @param tag for 'collection'. |
97
|
|
| 'if' construct must use '{}'s. |
98
|
|
| 'else' construct must use '{}'s. |
108
|
|
| Line has trailing spaces. |
117
|
|
| Expected an @return tag. |
121
|
|
| Parameter map should be final. |
121
|
|
| Expected @param tag for 'map'. |
121
|
|
| 'if' construct must use '{}'s. |
122
|
|
| 'else' construct must use '{}'s. |
130
|
net/sf/oness/common/model/util/PaginatedList.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
34
|
|
| Line has trailing spaces. |
36
|
|
| Missing a Javadoc comment. |
42
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| Line is longer than 80 characters. |
48
|
|
| Missing a Javadoc comment. |
48
|
|
| Parameter list should be final. |
48
|
|
| 'list' hides a field. |
48
|
|
| Parameter firstElement should be final. |
48
|
|
| 'firstElement' hides a field. |
48
|
|
| Parameter maxElements should be final. |
48
|
|
| 'maxElements' hides a field. |
48
|
|
| Parameter size should be final. |
48
|
|
| 'size' hides a field. |
48
|
|
| First sentence should end with a period. |
55
|
|
| Expected an @return tag. |
59
|
|
| Method 'getList' is not designed for extension - needs to be abstract, final or empty. |
59
|
|
| Method 'setList' is not designed for extension - needs to be abstract, final or empty. |
63
|
|
| Missing a Javadoc comment. |
63
|
|
| Parameter list should be final. |
63
|
|
| 'list' hides a field. |
63
|
|
| First sentence should end with a period. |
67
|
|
| Expected an @return tag. |
71
|
|
| Method 'getFirstElement' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Method 'setFirstElement' is not designed for extension - needs to be abstract, final or empty. |
75
|
|
| Missing a Javadoc comment. |
75
|
|
| Parameter firstElement should be final. |
75
|
|
| 'firstElement' hides a field. |
75
|
|
| First sentence should end with a period. |
79
|
|
| Expected an @return tag. |
83
|
|
| Method 'getMaxElements' is not designed for extension - needs to be abstract, final or empty. |
83
|
|
| Method 'setMaxElements' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Missing a Javadoc comment. |
87
|
|
| Parameter maxElements should be final. |
87
|
|
| 'maxElements' hides a field. |
87
|
|
| First sentence should end with a period. |
91
|
|
| Line has trailing spaces. |
92
|
|
| Method 'setSize' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Parameter size should be final. |
94
|
|
| 'size' hides a field. |
94
|
|
| Expected @param tag for 'size'. |
94
|
|
| First sentence should end with a period. |
98
|
|
| Expected an @return tag. |
102
|
|
| Method 'getPageSize' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
| First sentence should end with a period. |
106
|
|
| Expected an @return tag. |
110
|
|
| Method 'getPageNumber' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
| First sentence should end with a period. |
114
|
|
| Expected an @return tag. |
118
|
|
| Method 'getLastPageNumber' is not designed for extension - needs to be abstract, final or empty. |
118
|
|
| First sentence should end with a period. |
124
|
|
| Method 'iterator' is not designed for extension - needs to be abstract, final or empty. |
129
|
|
| First sentence should end with a period. |
133
|
|
| Line has trailing spaces. |
134
|
|
| Method 'size' is not designed for extension - needs to be abstract, final or empty. |
137
|
|
| First sentence should end with a period. |
141
|
|
| Line has trailing spaces. |
142
|
|
| Method 'getSize' is not designed for extension - needs to be abstract, final or empty. |
145
|
|
| First sentence should end with a period. |
151
|
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
156
|
|
| Parameter arg0 should be final. |
156
|
|
| Parameter arg1 should be final. |
156
|
|
| First sentence should end with a period. |
160
|
|
| Method 'add' is not designed for extension - needs to be abstract, final or empty. |
165
|
|
| Parameter arg0 should be final. |
165
|
|
| First sentence should end with a period. |
169
|
|
| Method 'addAll' is not designed for extension - needs to be abstract, final or empty. |
174
|
|
| Parameter arg0 should be final. |
174
|
|
| First sentence should end with a period. |
178
|
|
| Method 'addAll' is not designed for extension - needs to be abstract, final or empty. |
183
|
|
| Parameter arg0 should be final. |
183
|
|
| Parameter arg1 should be final. |
183
|
|
| First sentence should end with a period. |
187
|
|
| Method 'clear' is not designed for extension - needs to be abstract, final or empty. |
192
|
|
| First sentence should end with a period. |
197
|
|
| Method 'contains' is not designed for extension - needs to be abstract, final or empty. |
202
|
|
| Parameter arg0 should be final. |
202
|
|
| First sentence should end with a period. |
206
|
|
| Method 'containsAll' is not designed for extension - needs to be abstract, final or empty. |
211
|
|
| Parameter arg0 should be final. |
211
|
|
| First sentence should end with a period. |
215
|
|
| Method 'get' is not designed for extension - needs to be abstract, final or empty. |
220
|
|
| Parameter arg0 should be final. |
220
|
|
| First sentence should end with a period. |
224
|
|
| Method 'indexOf' is not designed for extension - needs to be abstract, final or empty. |
229
|
|
| Parameter arg0 should be final. |
229
|
|
| First sentence should end with a period. |
233
|
|
| Method 'isEmpty' is not designed for extension - needs to be abstract, final or empty. |
238
|
|
| First sentence should end with a period. |
242
|
|
| Method 'lastIndexOf' is not designed for extension - needs to be abstract, final or empty. |
247
|
|
| Parameter arg0 should be final. |
247
|
|
| First sentence should end with a period. |
251
|
|
| Method 'listIterator' is not designed for extension - needs to be abstract, final or empty. |
256
|
|
| First sentence should end with a period. |
260
|
|
| Method 'listIterator' is not designed for extension - needs to be abstract, final or empty. |
265
|
|
| Parameter arg0 should be final. |
265
|
|
| First sentence should end with a period. |
269
|
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
274
|
|
| Parameter arg0 should be final. |
274
|
|
| First sentence should end with a period. |
278
|
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
283
|
|
| Parameter arg0 should be final. |
283
|
|
| First sentence should end with a period. |
287
|
|
| Method 'removeAll' is not designed for extension - needs to be abstract, final or empty. |
292
|
|
| Parameter arg0 should be final. |
292
|
|
| First sentence should end with a period. |
296
|
|
| Method 'retainAll' is not designed for extension - needs to be abstract, final or empty. |
301
|
|
| Parameter arg0 should be final. |
301
|
|
| First sentence should end with a period. |
305
|
|
| Method 'set' is not designed for extension - needs to be abstract, final or empty. |
310
|
|
| Parameter arg0 should be final. |
310
|
|
| Parameter arg1 should be final. |
310
|
|
| First sentence should end with a period. |
314
|
|
| Method 'subList' is not designed for extension - needs to be abstract, final or empty. |
319
|
|
| Parameter arg0 should be final. |
319
|
|
| Parameter arg1 should be final. |
319
|
|
| First sentence should end with a period. |
323
|
|
| Method 'toArray' is not designed for extension - needs to be abstract, final or empty. |
328
|
|
| First sentence should end with a period. |
332
|
|
| Method 'toArray' is not designed for extension - needs to be abstract, final or empty. |
337
|
|
| Parameter arg0 should be final. |
337
|
net/sf/oness/common/model/util/PaginatedListIterator.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Missing a Javadoc comment. |
29
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
31
|
|
| Parameter list should be final. |
36
|
|
| 'list' hides a field. |
36
|
|
| Expected @param tag for 'list'. |
36
|
|
| Method 'hasNext' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Method 'next' is not designed for extension - needs to be abstract, final or empty. |
53
|
|
| First sentence should end with a period. |
72
|
|
| Method 'remove' is not designed for extension - needs to be abstract, final or empty. |
77
|
net/sf/oness/common/model/util/dbunit/DatabasePopulator.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/util/dbunit/DatabasePopulator.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
43
|
|
| Missing a Javadoc comment. |
49
|
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
49
|
|
| Missing a Javadoc comment. |
51
|
|
| Missing a Javadoc comment. |
53
|
|
| Line has trailing spaces. |
57
|
|
| Method 'setLocations' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Parameter locations should be final. |
61
|
|
| 'locations' hides a field. |
61
|
|
| Method 'getLocations' is not designed for extension - needs to be abstract, final or empty. |
68
|
|
| First sentence should end with a period. |
72
|
|
| Line has trailing spaces. |
74
|
|
| Method 'setDataSource' is not designed for extension - needs to be abstract, final or empty. |
78
|
|
| Parameter dataSource should be final. |
78
|
|
| 'dataSource' hides a field. |
78
|
|
| Method 'getDataSource' is not designed for extension - needs to be abstract, final or empty. |
85
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
89
|
|
| Missing a Javadoc comment. |
89
|
|
| 'if' construct must use '{}'s. |
90
|
|
| 'if' construct must use '{}'s. |
103
|
|
| 'if' construct must use '{}'s. |
108
|
|
| 'if' construct must use '{}'s. |
112
|
|
| Line is longer than 80 characters. |
126
|
|
| 'if' construct must use '{}'s. |
128
|
net/sf/oness/common/model/util/dbunit/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/util/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/model/util/spring/ListConcatenator.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/model/util/spring/ListConcatenator.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
22
|
|
| Line has trailing spaces. |
24
|
|
| Missing a Javadoc comment. |
30
|
|
| Parameter list should be final. |
30
|
net/sf/oness/common/model/util/spring/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
