Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 15 | 0 | 0 | 196 |
Files
net/sf/oness/inventory/webapp/controller/action/ModelAction.java
| Error | Line |
|---|
| File does not end with a newline. |
0
|
net/sf/oness/inventory/webapp/controller/action/ModelAction.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
37
|
|
| Line has trailing spaces. |
39
|
|
| Line has trailing spaces. |
47
|
|
| Method 'create' is not designed for extension - needs to be abstract, final or empty. |
55
|
|
| Parameter mapping should be final. |
55
|
|
| Expected @param tag for 'mapping'. |
55
|
|
| Parameter actionForm should be final. |
55
|
|
| Expected @param tag for 'actionForm'. |
55
|
|
| Parameter request should be final. |
56
|
|
| Expected @param tag for 'request'. |
56
|
|
| Parameter response should be final. |
56
|
|
| Expected @param tag for 'response'. |
56
|
|
| Expected @throws tag for 'Exception'. |
57
|
|
| Line has trailing spaces. |
72
|
|
| Method 'update' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Parameter mapping should be final. |
80
|
|
| Expected @param tag for 'mapping'. |
80
|
|
| Parameter actionForm should be final. |
80
|
|
| Expected @param tag for 'actionForm'. |
80
|
|
| Parameter request should be final. |
81
|
|
| Expected @param tag for 'request'. |
81
|
|
| Parameter response should be final. |
81
|
|
| Expected @param tag for 'response'. |
81
|
|
| Expected @throws tag for 'Exception'. |
82
|
|
| Line has trailing spaces. |
92
|
|
| Method 'find' is not designed for extension - needs to be abstract, final or empty. |
100
|
|
| Parameter mapping should be final. |
100
|
|
| Expected @param tag for 'mapping'. |
100
|
|
| Parameter actionForm should be final. |
100
|
|
| Expected @param tag for 'actionForm'. |
100
|
|
| Parameter request should be final. |
101
|
|
| Expected @param tag for 'request'. |
101
|
|
| Parameter response should be final. |
101
|
|
| Expected @param tag for 'response'. |
101
|
|
| Expected @throws tag for 'Exception'. |
102
|
|
| Line has trailing spaces. |
122
|
|
| Method 'show' is not designed for extension - needs to be abstract, final or empty. |
130
|
|
| Parameter mapping should be final. |
130
|
|
| Expected @param tag for 'mapping'. |
130
|
|
| Parameter actionForm should be final. |
130
|
|
| Expected @param tag for 'actionForm'. |
130
|
|
| Parameter request should be final. |
131
|
|
| Expected @param tag for 'request'. |
131
|
|
| Parameter response should be final. |
131
|
|
| Expected @param tag for 'response'. |
131
|
|
| Expected @throws tag for 'Exception'. |
132
|
|
| Line has trailing spaces. |
142
|
|
| Method 'edit' is not designed for extension - needs to be abstract, final or empty. |
150
|
|
| Parameter mapping should be final. |
150
|
|
| Expected @param tag for 'mapping'. |
150
|
|
| Parameter actionForm should be final. |
150
|
|
| Expected @param tag for 'actionForm'. |
150
|
|
| Parameter request should be final. |
151
|
|
| Expected @param tag for 'request'. |
151
|
|
| Parameter response should be final. |
151
|
|
| Expected @param tag for 'response'. |
151
|
|
| Expected @throws tag for 'Exception'. |
152
|
|
| Line has trailing spaces. |
161
|
|
| Method 'delete' is not designed for extension - needs to be abstract, final or empty. |
169
|
|
| Parameter mapping should be final. |
169
|
|
| Expected @param tag for 'mapping'. |
169
|
|
| Parameter actionForm should be final. |
169
|
|
| Expected @param tag for 'actionForm'. |
169
|
|
| Parameter request should be final. |
170
|
|
| Expected @param tag for 'request'. |
170
|
|
| Parameter response should be final. |
170
|
|
| Expected @param tag for 'response'. |
170
|
|
| Expected @throws tag for 'Exception'. |
171
|
|
| Missing a Javadoc comment. |
177
|
|
| Missing a Javadoc comment. |
181
|
|
| Parameter actionForm should be final. |
181
|
|
| Missing a Javadoc comment. |
186
|
|
| Parameter actionForm should be final. |
186
|
|
| Missing a Javadoc comment. |
190
|
|
| Parameter actionForm should be final. |
190
|
|
| Missing a Javadoc comment. |
195
|
|
| Parameter request should be final. |
195
|
|
| Parameter model should be final. |
195
|
net/sf/oness/inventory/webapp/controller/action/PriceAction.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/inventory/webapp/controller/action/PriceAction.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line is longer than 80 characters. |
35
|
|
| First sentence should end with a period. |
42
|
|
| Line has trailing spaces. |
44
|
|
| Line has trailing spaces. |
52
|
|
| Method 'update' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
| Parameter mapping should be final. |
60
|
|
| Expected @param tag for 'mapping'. |
60
|
|
| Parameter actionForm should be final. |
60
|
|
| Expected @param tag for 'actionForm'. |
60
|
|
| Parameter request should be final. |
61
|
|
| Expected @param tag for 'request'. |
61
|
|
| Parameter response should be final. |
61
|
|
| Expected @param tag for 'response'. |
61
|
|
| Expected @throws tag for 'Exception'. |
62
|
|
| Line has trailing spaces. |
98
|
|
| Method 'edit' is not designed for extension - needs to be abstract, final or empty. |
106
|
|
| Parameter mapping should be final. |
106
|
|
| Expected @param tag for 'mapping'. |
106
|
|
| Parameter actionForm should be final. |
106
|
|
| Expected @param tag for 'actionForm'. |
106
|
|
| Parameter request should be final. |
107
|
|
| Expected @param tag for 'request'. |
107
|
|
| Parameter response should be final. |
107
|
|
| Expected @param tag for 'response'. |
107
|
|
| Expected @throws tag for 'Exception'. |
108
|
|
| Line is longer than 80 characters. |
120
|
|
| Line is longer than 80 characters. |
132
|
|
| Avoid inline conditionals. |
155
|
|
| Missing a Javadoc comment. |
164
|
net/sf/oness/inventory/webapp/controller/action/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/inventory/webapp/controller/actionform/PriceActionForm.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/inventory/webapp/controller/actionform/PriceActionForm.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Missing a Javadoc comment. |
28
|
|
| Method 'setAmount' is not designed for extension - needs to be abstract, final or empty. |
34
|
|
| Parameter amount should be final. |
34
|
|
| 'amount' hides a field. |
34
|
|
| Method 'getAmount' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Method 'setFareId' is not designed for extension - needs to be abstract, final or empty. |
49
|
|
| Parameter fareId should be final. |
49
|
|
| 'fareId' hides a field. |
49
|
|
| Method 'getFareId' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
60
|
|
| Missing a Javadoc comment. |
60
|
net/sf/oness/inventory/webapp/controller/actionform/PricesActionForm.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/inventory/webapp/controller/actionform/PricesActionForm.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Missing a Javadoc comment. |
31
|
|
| Line is longer than 80 characters. |
33
|
|
| Missing a Javadoc comment. |
33
|
|
| '10' is a magic number. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Unused @param tag for 'modelId'. |
40
|
|
| Method 'setModelId' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Parameter id should be final. |
43
|
|
| Expected @param tag for 'id'. |
43
|
|
| Method 'getModelId' is not designed for extension - needs to be abstract, final or empty. |
50
|
|
| Method 'setProductPrices' is not designed for extension - needs to be abstract, final or empty. |
58
|
|
| Parameter productPrices should be final. |
58
|
|
| 'productPrices' hides a field. |
58
|
|
| Method 'getProductPrices' is not designed for extension - needs to be abstract, final or empty. |
65
|
|
| Method 'setProductPricesSize' is not designed for extension - needs to be abstract, final or empty. |
73
|
|
| Parameter productPricesSize should be final. |
73
|
|
| 'productPricesSize' hides a field. |
73
|
|
| Method 'getProductPricesSize' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Method 'setFaresSize' is not designed for extension - needs to be abstract, final or empty. |
87
|
|
| Parameter faresSize should be final. |
87
|
|
| 'faresSize' hides a field. |
87
|
|
| Method 'getFaresSize' is not designed for extension - needs to be abstract, final or empty. |
94
|
|
| Line is longer than 80 characters. |
99
|
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
102
|
|
| Parameter mapping should be final. |
102
|
|
| Parameter request should be final. |
102
|
|
| 'productPricesSize' hides a field. |
105
|
|
| Avoid inline conditionals. |
106
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
116
|
|
| Missing a Javadoc comment. |
116
|
net/sf/oness/inventory/webapp/controller/actionform/ProductPricesActionForm.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/inventory/webapp/controller/actionform/ProductPricesActionForm.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Missing a Javadoc comment. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Unused @param tag for 'id'. |
36
|
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Parameter productId should be final. |
39
|
|
| Expected @param tag for 'productId'. |
39
|
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
46
|
|
| Method 'setStockKeepingUnit' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Parameter stockKeepingUnit should be final. |
54
|
|
| 'stockKeepingUnit' hides a field. |
54
|
|
| Method 'getStockKeepingUnit' is not designed for extension - needs to be abstract, final or empty. |
61
|
|
| Method 'setPrices' is not designed for extension - needs to be abstract, final or empty. |
69
|
|
| Parameter prices should be final. |
69
|
|
| 'prices' hides a field. |
69
|
|
| Method 'getPrices' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Line is longer than 80 characters. |
81
|
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
84
|
|
| Parameter mapping should be final. |
84
|
|
| Parameter request should be final. |
84
|
|
| Avoid inline conditionals. |
88
|
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
97
|
|
| Missing a Javadoc comment. |
97
|
net/sf/oness/inventory/webapp/controller/actionform/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/inventory/webapp/controller/listener/StartupListener.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/inventory/webapp/controller/listener/StartupListener.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line is longer than 80 characters. |
20
|
|
| Line has trailing spaces. |
27
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
35
|
|
| Missing a Javadoc comment. |
37
|
|
| Line is longer than 80 characters. |
40
|
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
43
|
|
| Parameter applicationContext should be final. |
43
|
|
| Parameter servletContext should be final. |
44
|
|
| Line is longer than 80 characters. |
48
|
net/sf/oness/inventory/webapp/controller/listener/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
