Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
16 | 0 | 0 | 343 |
Files
net/sf/oness/order/webapp/controller/action/AbstractAction.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/order/webapp/controller/action/AbstractAction.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| Line has trailing spaces. |
23
|
| Line is longer than 80 characters. |
29
|
| Missing a Javadoc comment. |
29
|
| Line is longer than 80 characters. |
31
|
| Missing a Javadoc comment. |
31
|
| Method 'getFacade' is not designed for extension - needs to be abstract, final or empty. |
33
|
| Missing a Javadoc comment. |
33
|
net/sf/oness/order/webapp/controller/action/DeliveryDocketAction.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/order/webapp/controller/action/DeliveryDocketAction.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| First sentence should end with a period. |
45
|
| Line has trailing spaces. |
47
|
| Line has trailing spaces. |
55
|
| Method 'create' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Parameter mapping should be final. |
63
|
| Expected @param tag for 'mapping'. |
63
|
| Parameter actionForm should be final. |
63
|
| Expected @param tag for 'actionForm'. |
63
|
| Parameter request should be final. |
64
|
| Expected @param tag for 'request'. |
64
|
| Parameter response should be final. |
64
|
| Expected @param tag for 'response'. |
64
|
| Expected @throws tag for 'Exception'. |
65
|
| 'if' construct must use '{}'s. |
68
|
| Line has trailing spaces. |
98
|
| Method 'update' is not designed for extension - needs to be abstract, final or empty. |
106
|
| Parameter mapping should be final. |
106
|
| Expected @param tag for 'mapping'. |
106
|
| Parameter actionForm should be final. |
106
|
| Expected @param tag for 'actionForm'. |
106
|
| Parameter request should be final. |
107
|
| Expected @param tag for 'request'. |
107
|
| Parameter response should be final. |
107
|
| Expected @param tag for 'response'. |
107
|
| Expected @throws tag for 'Exception'. |
108
|
| 'if' construct must use '{}'s. |
112
|
| Line has trailing spaces. |
130
|
| Method 'find' is not designed for extension - needs to be abstract, final or empty. |
138
|
| Parameter mapping should be final. |
138
|
| Expected @param tag for 'mapping'. |
138
|
| Parameter actionForm should be final. |
138
|
| Expected @param tag for 'actionForm'. |
138
|
| Parameter request should be final. |
139
|
| Expected @param tag for 'request'. |
139
|
| Parameter response should be final. |
139
|
| Expected @param tag for 'response'. |
139
|
| Expected @throws tag for 'Exception'. |
140
|
| 'if' construct must use '{}'s. |
143
|
| Line has trailing spaces. |
162
|
| Method 'show' is not designed for extension - needs to be abstract, final or empty. |
170
|
| Parameter mapping should be final. |
170
|
| Expected @param tag for 'mapping'. |
170
|
| Parameter actionForm should be final. |
170
|
| Expected @param tag for 'actionForm'. |
170
|
| Parameter request should be final. |
171
|
| Expected @param tag for 'request'. |
171
|
| Parameter response should be final. |
171
|
| Expected @param tag for 'response'. |
171
|
| Expected @throws tag for 'Exception'. |
172
|
| Line has trailing spaces. |
188
|
| Method 'edit' is not designed for extension - needs to be abstract, final or empty. |
196
|
| Parameter mapping should be final. |
196
|
| Expected @param tag for 'mapping'. |
196
|
| Parameter actionForm should be final. |
196
|
| Expected @param tag for 'actionForm'. |
196
|
| Parameter request should be final. |
197
|
| Expected @param tag for 'request'. |
197
|
| Parameter response should be final. |
197
|
| Expected @param tag for 'response'. |
197
|
| Expected @throws tag for 'Exception'. |
198
|
| Line has trailing spaces. |
222
|
| Method 'delete' is not designed for extension - needs to be abstract, final or empty. |
230
|
| Parameter mapping should be final. |
230
|
| Expected @param tag for 'mapping'. |
230
|
| Parameter actionForm should be final. |
230
|
| Expected @param tag for 'actionForm'. |
230
|
| Parameter request should be final. |
231
|
| Expected @param tag for 'request'. |
231
|
| Parameter response should be final. |
231
|
| Expected @param tag for 'response'. |
231
|
| Expected @throws tag for 'Exception'. |
232
|
| Missing a Javadoc comment. |
238
|
| Parameter actionForm should be final. |
238
|
| Parameter request should be final. |
239
|
| 'if' construct must use '{}'s. |
249
|
| 'if' construct must use '{}'s. |
251
|
| Missing a Javadoc comment. |
257
|
| Parameter actionForm should be final. |
257
|
| Parameter request should be final. |
258
|
| 'if' construct must use '{}'s. |
267
|
| 'if' construct must use '{}'s. |
277
|
| 'if' construct must use '{}'s. |
286
|
| Line is longer than 80 characters. |
286
|
| Missing a Javadoc comment. |
293
|
| Parameter actionForm should be final. |
293
|
| First sentence should end with a period. |
298
|
| Line has trailing spaces. |
300
|
| Parameter request should be final. |
303
|
| Expected @param tag for 'request'. |
303
|
| Parameter deliveryDocket should be final. |
304
|
| Expected @param tag for 'deliveryDocket'. |
304
|
| Missing a Javadoc comment. |
310
|
| Parameter deliveryDocket should be final. |
310
|
| Parameter actionForm should be final. |
311
|
net/sf/oness/order/webapp/controller/action/InvoiceAction.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/order/webapp/controller/action/InvoiceAction.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| First sentence should end with a period. |
36
|
| Line has trailing spaces. |
38
|
| Line has trailing spaces. |
46
|
| Method 'create' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Parameter mapping should be final. |
54
|
| Expected @param tag for 'mapping'. |
54
|
| Parameter actionForm should be final. |
54
|
| Expected @param tag for 'actionForm'. |
54
|
| Parameter request should be final. |
55
|
| Expected @param tag for 'request'. |
55
|
| Parameter response should be final. |
55
|
| Expected @param tag for 'response'. |
55
|
| Expected @throws tag for 'Exception'. |
56
|
| 'if' construct must use '{}'s. |
63
|
| Line has trailing spaces. |
75
|
| Method 'find' is not designed for extension - needs to be abstract, final or empty. |
83
|
| Parameter mapping should be final. |
83
|
| Expected @param tag for 'mapping'. |
83
|
| Parameter actionForm should be final. |
83
|
| Expected @param tag for 'actionForm'. |
83
|
| Parameter request should be final. |
84
|
| Expected @param tag for 'request'. |
84
|
| Parameter response should be final. |
84
|
| Expected @param tag for 'response'. |
84
|
| Expected @throws tag for 'Exception'. |
85
|
| 'if' construct must use '{}'s. |
88
|
| Line has trailing spaces. |
105
|
| Method 'show' is not designed for extension - needs to be abstract, final or empty. |
113
|
| Parameter mapping should be final. |
113
|
| Expected @param tag for 'mapping'. |
113
|
| Parameter actionForm should be final. |
113
|
| Expected @param tag for 'actionForm'. |
113
|
| Parameter request should be final. |
114
|
| Expected @param tag for 'request'. |
114
|
| Parameter response should be final. |
114
|
| Expected @param tag for 'response'. |
114
|
| Expected @throws tag for 'Exception'. |
115
|
| Line is longer than 80 characters. |
129
|
| Missing a Javadoc comment. |
129
|
| Parameter actionForm should be final. |
129
|
| Parameter request should be final. |
129
|
| 'if' construct must use '{}'s. |
138
|
| 'if' construct must use '{}'s. |
140
|
| Missing a Javadoc comment. |
146
|
| Parameter actionForm should be final. |
146
|
| Missing a Javadoc comment. |
151
|
| Parameter invoice should be final. |
151
|
| Parameter actionForm should be final. |
151
|
net/sf/oness/order/webapp/controller/action/OrderAction.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/order/webapp/controller/action/OrderAction.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| First sentence should end with a period. |
42
|
| Line has trailing spaces. |
44
|
| Line has trailing spaces. |
52
|
| Method 'create' is not designed for extension - needs to be abstract, final or empty. |
60
|
| Parameter mapping should be final. |
60
|
| Expected @param tag for 'mapping'. |
60
|
| Parameter actionForm should be final. |
60
|
| Expected @param tag for 'actionForm'. |
60
|
| Parameter request should be final. |
61
|
| Expected @param tag for 'request'. |
61
|
| Parameter response should be final. |
61
|
| Expected @param tag for 'response'. |
61
|
| Expected @throws tag for 'Exception'. |
62
|
| 'if' construct must use '{}'s. |
65
|
| Line has trailing spaces. |
83
|
| Method 'update' is not designed for extension - needs to be abstract, final or empty. |
91
|
| Parameter mapping should be final. |
91
|
| Expected @param tag for 'mapping'. |
91
|
| Parameter actionForm should be final. |
91
|
| Expected @param tag for 'actionForm'. |
91
|
| Parameter request should be final. |
92
|
| Expected @param tag for 'request'. |
92
|
| Parameter response should be final. |
92
|
| Expected @param tag for 'response'. |
92
|
| Expected @throws tag for 'Exception'. |
93
|
| 'if' construct must use '{}'s. |
97
|
| Line has trailing spaces. |
113
|
| Method 'find' is not designed for extension - needs to be abstract, final or empty. |
121
|
| Parameter mapping should be final. |
121
|
| Expected @param tag for 'mapping'. |
121
|
| Parameter actionForm should be final. |
121
|
| Expected @param tag for 'actionForm'. |
121
|
| Parameter request should be final. |
122
|
| Expected @param tag for 'request'. |
122
|
| Parameter response should be final. |
122
|
| Expected @param tag for 'response'. |
122
|
| Expected @throws tag for 'Exception'. |
123
|
| 'if' construct must use '{}'s. |
126
|
| Line has trailing spaces. |
143
|
| Method 'show' is not designed for extension - needs to be abstract, final or empty. |
151
|
| Parameter mapping should be final. |
151
|
| Expected @param tag for 'mapping'. |
151
|
| Parameter actionForm should be final. |
151
|
| Expected @param tag for 'actionForm'. |
151
|
| Parameter request should be final. |
152
|
| Expected @param tag for 'request'. |
152
|
| Parameter response should be final. |
152
|
| Expected @param tag for 'response'. |
152
|
| Expected @throws tag for 'Exception'. |
153
|
| Line has trailing spaces. |
169
|
| Method 'edit' is not designed for extension - needs to be abstract, final or empty. |
177
|
| Parameter mapping should be final. |
177
|
| Expected @param tag for 'mapping'. |
177
|
| Parameter actionForm should be final. |
177
|
| Expected @param tag for 'actionForm'. |
177
|
| Parameter request should be final. |
178
|
| Expected @param tag for 'request'. |
178
|
| Parameter response should be final. |
178
|
| Expected @param tag for 'response'. |
178
|
| Expected @throws tag for 'Exception'. |
179
|
| Line has trailing spaces. |
202
|
| Method 'delete' is not designed for extension - needs to be abstract, final or empty. |
210
|
| Parameter mapping should be final. |
210
|
| Expected @param tag for 'mapping'. |
210
|
| Parameter actionForm should be final. |
210
|
| Expected @param tag for 'actionForm'. |
210
|
| Parameter request should be final. |
211
|
| Expected @param tag for 'request'. |
211
|
| Parameter response should be final. |
211
|
| Expected @param tag for 'response'. |
211
|
| Expected @throws tag for 'Exception'. |
212
|
| Missing a Javadoc comment. |
218
|
| Parameter actionForm should be final. |
218
|
| Parameter request should be final. |
218
|
| 'if' construct must use '{}'s. |
227
|
| 'if' construct must use '{}'s. |
229
|
| Missing a Javadoc comment. |
235
|
| Parameter actionForm should be final. |
235
|
| Line is longer than 80 characters. |
236
|
| Parameter request should be final. |
236
|
| Parameter mapping should be final. |
236
|
| 'if' construct must use '{}'s. |
245
|
| 'if' construct must use '{}'s. |
256
|
| Missing a Javadoc comment. |
270
|
| Parameter actionForm should be final. |
270
|
| First sentence should end with a period. |
275
|
| Line has trailing spaces. |
277
|
| Parameter request should be final. |
280
|
| Expected @param tag for 'request'. |
280
|
| Parameter order should be final. |
280
|
| Expected @param tag for 'order'. |
280
|
| Missing a Javadoc comment. |
285
|
| Parameter order should be final. |
285
|
| Parameter actionForm should be final. |
285
|
net/sf/oness/order/webapp/controller/action/OrderItemAction.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/order/webapp/controller/action/OrderItemAction.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| First sentence should end with a period. |
38
|
| Line has trailing spaces. |
40
|
| Line has trailing spaces. |
48
|
| Method 'create' is not designed for extension - needs to be abstract, final or empty. |
56
|
| Parameter mapping should be final. |
56
|
| Expected @param tag for 'mapping'. |
56
|
| Parameter actionForm should be final. |
56
|
| Expected @param tag for 'actionForm'. |
56
|
| Parameter request should be final. |
57
|
| Expected @param tag for 'request'. |
57
|
| Parameter response should be final. |
57
|
| Expected @param tag for 'response'. |
57
|
| Expected @throws tag for 'Exception'. |
58
|
| 'if' construct must use '{}'s. |
67
|
| 'if' construct must use '{}'s. |
90
|
| 'if' construct must use '{}'s. |
96
|
net/sf/oness/order/webapp/controller/action/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sf/oness/order/webapp/controller/actionform/ItemActionForm.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/order/webapp/controller/actionform/ItemActionForm.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| Missing a Javadoc comment. |
26
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Parameter id should be final. |
32
|
| 'id' hides a field. |
32
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
39
|
| Method 'setProductId' is not designed for extension - needs to be abstract, final or empty. |
47
|
| Parameter productId should be final. |
47
|
| 'productId' hides a field. |
47
|
| Method 'getProductId' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Method 'setQuantity' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Parameter quantity should be final. |
62
|
| 'quantity' hides a field. |
62
|
| Method 'getQuantity' is not designed for extension - needs to be abstract, final or empty. |
69
|
| Method 'setPrice' is not designed for extension - needs to be abstract, final or empty. |
77
|
| Parameter price should be final. |
77
|
| 'price' hides a field. |
77
|
| Method 'getPrice' is not designed for extension - needs to be abstract, final or empty. |
84
|
net/sf/oness/order/webapp/controller/actionform/MasterActionForm.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/order/webapp/controller/actionform/MasterActionForm.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| Missing a Javadoc comment. |
40
|
| '10' is a magic number. |
40
|
| Missing a Javadoc comment. |
42
|
| Missing a Javadoc comment. |
44
|
| Missing a Javadoc comment. |
46
|
| Method 'setId' is not designed for extension - needs to be abstract, final or empty. |
52
|
| Parameter id should be final. |
52
|
| 'id' hides a field. |
52
|
| Method 'getId' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Method 'setDateAsString' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Parameter dateAsString should be final. |
67
|
| 'dateAsString' hides a field. |
67
|
| Method 'getDateAsString' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Method 'setPartyId' is not designed for extension - needs to be abstract, final or empty. |
82
|
| Parameter partyId should be final. |
82
|
| 'partyId' hides a field. |
82
|
| Method 'getPartyId' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Method 'setComments' is not designed for extension - needs to be abstract, final or empty. |
97
|
| Parameter comments should be final. |
97
|
| 'comments' hides a field. |
97
|
| Method 'getComments' is not designed for extension - needs to be abstract, final or empty. |
104
|
| Method 'setItems' is not designed for extension - needs to be abstract, final or empty. |
112
|
| Parameter items should be final. |
112
|
| 'items' hides a field. |
112
|
| Method 'getItems' is not designed for extension - needs to be abstract, final or empty. |
119
|
| Method 'setItemsSize' is not designed for extension - needs to be abstract, final or empty. |
127
|
| Parameter itemsSize should be final. |
127
|
| 'itemsSize' hides a field. |
127
|
| Method 'getItemsSize' is not designed for extension - needs to be abstract, final or empty. |
134
|
| Method 'setDate' is not designed for extension - needs to be abstract, final or empty. |
142
|
| Parameter date should be final. |
142
|
| 'date' hides a field. |
142
|
| Method 'getDate' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Method 'setType' is not designed for extension - needs to be abstract, final or empty. |
157
|
| Parameter type should be final. |
157
|
| 'type' hides a field. |
157
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
164
|
| Line is longer than 80 characters. |
169
|
| Method 'reset' is not designed for extension - needs to be abstract, final or empty. |
172
|
| Parameter mapping should be final. |
172
|
| Parameter request should be final. |
172
|
| 'itemsSize' hides a field. |
175
|
| 'if' construct must use '{}'s. |
177
|
| 'else' construct must use '{}'s. |
179
|
| Line is longer than 80 characters. |
190
|
| Method 'validate' is not designed for extension - needs to be abstract, final or empty. |
193
|
| Parameter mapping should be final. |
193
|
| Parameter request should be final. |
194
|
| 'if' construct must use '{}'s. |
205
|
| Method 'toString' is not designed for extension - needs to be abstract, final or empty. |
215
|
| Missing a Javadoc comment. |
215
|
net/sf/oness/order/webapp/controller/actionform/package.html
Error | Line |
| Missing package documentation file. | 0 |