Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
Files | Infos | Warnings | Errors |
31 | 0 | 0 | 396 |
Files
net/sf/oness/party/model/contact/bo/ContactInfo.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/contact/bo/ContactInfo.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| First sentence should end with a period. |
23
|
| Line has trailing spaces. |
25
|
| Line has trailing spaces. |
28
|
| Missing a Javadoc comment. |
34
|
| Missing a Javadoc comment. |
36
|
| Line has trailing spaces. |
37
|
| Method 'setPurposes' is not designed for extension - needs to be abstract, final or empty. |
38
|
| Missing a Javadoc comment. |
38
|
| Parameter purposes should be final. |
38
|
| 'purposes' hides a field. |
38
|
| Line has trailing spaces. |
46
|
| Method 'getPurposes' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Method 'setParty' is not designed for extension - needs to be abstract, final or empty. |
57
|
| Parameter party should be final. |
57
|
| 'party' hides a field. |
57
|
| Line has trailing spaces. |
63
|
| Method 'getParty' is not designed for extension - needs to be abstract, final or empty. |
66
|
net/sf/oness/party/model/contact/bo/Country.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/contact/bo/Country.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| First sentence should end with a period. |
20
|
| Line has trailing spaces. |
22
|
| Line has trailing spaces. |
24
|
| Missing a Javadoc comment. |
30
|
| Method 'setIsoCode' is not designed for extension - needs to be abstract, final or empty. |
32
|
| Missing a Javadoc comment. |
32
|
| Parameter code should be final. |
32
|
| Line has trailing spaces. |
38
|
| Expected an @return tag. |
41
|
| Method 'getIsoCode' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Method 'setTelephoneCode' is not designed for extension - needs to be abstract, final or empty. |
48
|
| Parameter telephoneCode should be final. |
48
|
| 'telephoneCode' hides a field. |
48
|
| Line has trailing spaces. |
53
|
| Line has trailing spaces. |
54
|
| Method 'getTelephoneCode' is not designed for extension - needs to be abstract, final or empty. |
57
|
net/sf/oness/party/model/contact/bo/EmailAddress.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| First sentence should end with a period. |
18
|
| Line has trailing spaces. |
20
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
28
|
| Method 'setEmail' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Parameter email should be final. |
30
|
| 'email' hides a field. |
30
|
| Line has trailing spaces. |
36
|
| Expected an @return tag. |
39
|
| Method 'getEmail' is not designed for extension - needs to be abstract, final or empty. |
39
|
net/sf/oness/party/model/contact/bo/PhoneNumber.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/contact/bo/PhoneNumber.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| First sentence should end with a period. |
19
|
| Line has trailing spaces. |
21
|
| Line has trailing spaces. |
23
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
35
|
| Line has trailing spaces. |
39
|
| Expected an @return tag. |
42
|
| Method 'getCountry' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Method 'setCountry' is not designed for extension - needs to be abstract, final or empty. |
46
|
| Missing a Javadoc comment. |
46
|
| Parameter country should be final. |
46
|
| 'country' hides a field. |
46
|
| Method 'setAreaCode' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Missing a Javadoc comment. |
50
|
| Parameter areaCode should be final. |
50
|
| 'areaCode' hides a field. |
50
|
| Line has trailing spaces. |
56
|
| Expected an @return tag. |
59
|
| Method 'getAreaCode' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Method 'setContactNumber' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Missing a Javadoc comment. |
63
|
| Parameter contactNumber should be final. |
63
|
| 'contactNumber' hides a field. |
63
|
| Line has trailing spaces. |
69
|
| Expected an @return tag. |
72
|
| Method 'getContactNumber' is not designed for extension - needs to be abstract, final or empty. |
72
|
| Method 'setExtension' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Missing a Javadoc comment. |
76
|
| Parameter extension should be final. |
76
|
| 'extension' hides a field. |
76
|
| Line has trailing spaces. |
82
|
| Expected an @return tag. |
85
|
| Method 'getExtension' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
92
|
net/sf/oness/party/model/contact/bo/PostalAddress.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/contact/bo/PostalAddress.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| First sentence should end with a period. |
19
|
| Line has trailing spaces. |
21
|
| Line has trailing spaces. |
23
|
| Missing a Javadoc comment. |
29
|
| Missing a Javadoc comment. |
31
|
| Missing a Javadoc comment. |
33
|
| Missing a Javadoc comment. |
35
|
| Missing a Javadoc comment. |
37
|
| Missing a Javadoc comment. |
39
|
| Method 'setState' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Missing a Javadoc comment. |
41
|
| Parameter state should be final. |
41
|
| 'state' hides a field. |
41
|
| Line has trailing spaces. |
46
|
| Line has trailing spaces. |
47
|
| Expected an @return tag. |
50
|
| Method 'getState' is not designed for extension - needs to be abstract, final or empty. |
50
|
| Method 'setZip' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Missing a Javadoc comment. |
54
|
| Parameter zip should be final. |
54
|
| 'zip' hides a field. |
54
|
| Line has trailing spaces. |
59
|
| Line has trailing spaces. |
60
|
| Expected an @return tag. |
63
|
| Method 'getZip' is not designed for extension - needs to be abstract, final or empty. |
63
|
| Method 'setAddressee' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Missing a Javadoc comment. |
67
|
| Parameter addressee should be final. |
67
|
| 'addressee' hides a field. |
67
|
| Line has trailing spaces. |
73
|
| Expected an @return tag. |
76
|
| Method 'getAddressee' is not designed for extension - needs to be abstract, final or empty. |
76
|
| Method 'setAddress' is not designed for extension - needs to be abstract, final or empty. |
80
|
| Missing a Javadoc comment. |
80
|
| Parameter address should be final. |
80
|
| 'address' hides a field. |
80
|
| Line has trailing spaces. |
85
|
| Line has trailing spaces. |
86
|
| Expected an @return tag. |
89
|
| Method 'getAddress' is not designed for extension - needs to be abstract, final or empty. |
89
|
| Method 'setCity' is not designed for extension - needs to be abstract, final or empty. |
93
|
| Missing a Javadoc comment. |
93
|
| Parameter city should be final. |
93
|
| 'city' hides a field. |
93
|
| Line has trailing spaces. |
98
|
| Line has trailing spaces. |
99
|
| Expected an @return tag. |
102
|
| Method 'getCity' is not designed for extension - needs to be abstract, final or empty. |
102
|
| Method 'setCountry' is not designed for extension - needs to be abstract, final or empty. |
109
|
| Parameter country should be final. |
109
|
| 'country' hides a field. |
109
|
| Line has trailing spaces. |
115
|
| Method 'getCountry' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Method 'clone' is not designed for extension - needs to be abstract, final or empty. |
125
|
net/sf/oness/party/model/contact/bo/WebAddress.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| First sentence should end with a period. |
18
|
| Line has trailing spaces. |
20
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
28
|
| Method 'setUrl' is not designed for extension - needs to be abstract, final or empty. |
30
|
| Missing a Javadoc comment. |
30
|
| Parameter url should be final. |
30
|
| 'url' hides a field. |
30
|
| Line has trailing spaces. |
36
|
| Expected an @return tag. |
39
|
| Method 'getUrl' is not designed for extension - needs to be abstract, final or empty. |
39
|
net/sf/oness/party/model/contact/bo/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sf/oness/party/model/contact/dao/CountryDao.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/contact/dao/CountryDao.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| First sentence should end with a period. |
23
|
| Line has trailing spaces. |
25
|
| Missing a Javadoc comment. |
31
|
| Name 'clazz' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
31
|
| Method 'findById' is not designed for extension - needs to be abstract, final or empty. |
33
|
| Missing a Javadoc comment. |
33
|
| Parameter id should be final. |
33
|
net/sf/oness/party/model/contact/dao/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sf/oness/party/model/facade/PartyFacadeDelegate.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/facade/PartyFacadeDelegate.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| First sentence should end with a period. |
23
|
| Line has trailing spaces. |
25
|
| First sentence should end with a period. |
33
|
| Line has trailing spaces. |
35
|
| Redundant 'public' modifier. |
40
|
| Expected @param tag for 'party'. |
40
|
| Expected @throws tag for 'ExistingInstanceException'. |
41
|
| First sentence should end with a period. |
43
|
| Line has trailing spaces. |
45
|
| Line has trailing spaces. |
48
|
| Redundant 'public' modifier. |
55
|
| Expected @param tag for 'party'. |
55
|
| Expected @param tag for 'ignoreExisting'. |
55
|
| Expected @throws tag for 'ExistingInstanceException'. |
56
|
| First sentence should end with a period. |
58
|
| Line has trailing spaces. |
60
|
| Redundant 'public' modifier. |
65
|
| Expected @param tag for 'party'. |
65
|
| First sentence should end with a period. |
67
|
| Line has trailing spaces. |
69
|
| Redundant 'public' modifier. |
77
|
| Expected @param tag for 'firstElement'. |
78
|
| Expected @param tag for 'maxElements'. |
78
|
| Line has trailing spaces. |
82
|
| Redundant 'public' modifier. |
89
|
| Line has trailing spaces. |
93
|
| Redundant 'public' modifier. |
100
|
| First sentence should end with a period. |
102
|
| Line has trailing spaces. |
104
|
| Redundant 'public' modifier. |
110
|
| First sentence should end with a period. |
114
|
| Line has trailing spaces. |
116
|
| Redundant 'public' modifier. |
121
|
| Expected @param tag for 'contactInfo'. |
121
|
| First sentence should end with a period. |
123
|
| Line has trailing spaces. |
125
|
| Line is longer than 80 characters. |
130
|
| Redundant 'public' modifier. |
130
|
| Expected @param tag for 'contactInfo'. |
130
|
| First sentence should end with a period. |
132
|
| Line has trailing spaces. |
135
|
| Redundant 'public' modifier. |
143
|
| Expected @param tag for 'firstElement'. |
144
|
| Expected @param tag for 'maxElements'. |
145
|
| First sentence should end with a period. |
147
|
| Line has trailing spaces. |
149
|
| Redundant 'public' modifier. |
156
|
| First sentence should end with a period. |
158
|
| Line has trailing spaces. |
160
|
| Redundant 'public' modifier. |
166
|
net/sf/oness/party/model/facade/PartySpringFacadeDelegate.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/facade/PartySpringFacadeDelegate.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| First sentence should end with a period. |
28
|
| Line has trailing spaces. |
30
|
| Missing a Javadoc comment. |
36
|
| Missing a Javadoc comment. |
38
|
| Method 'setPartyDao' is not designed for extension - needs to be abstract, final or empty. |
44
|
| Parameter partyDao should be final. |
44
|
| 'partyDao' hides a field. |
44
|
| Method 'getPartyDao' is not designed for extension - needs to be abstract, final or empty. |
51
|
| Method 'setContactInfoDao' is not designed for extension - needs to be abstract, final or empty. |
59
|
| Parameter contactInfoDao should be final. |
59
|
| 'contactInfoDao' hides a field. |
59
|
| Method 'getContactInfoDao' is not designed for extension - needs to be abstract, final or empty. |
66
|
| Method 'setCountryDao' is not designed for extension - needs to be abstract, final or empty. |
74
|
| Parameter countryDao should be final. |
74
|
| 'countryDao' hides a field. |
74
|
| Method 'getCountryDao' is not designed for extension - needs to be abstract, final or empty. |
81
|
| Line is longer than 80 characters. |
88
|
| Method 'createParty' is not designed for extension - needs to be abstract, final or empty. |
90
|
| Parameter party should be final. |
90
|
| Line has trailing spaces. |
95
|
| Line is longer than 80 characters. |
96
|
| Method 'createParty' is not designed for extension - needs to be abstract, final or empty. |
99
|
| Parameter party should be final. |
99
|
| Parameter ignoreExisting should be final. |
99
|
| Line has trailing spaces. |
107
|
| Line is longer than 80 characters. |
108
|
| Method 'updateParty' is not designed for extension - needs to be abstract, final or empty. |
110
|
| Parameter party should be final. |
110
|
| Method 'findParty' is not designed for extension - needs to be abstract, final or empty. |
118
|
| Parameter party should be final. |
118
|
| Parameter firstElement should be final. |
118
|
| Parameter maxElements should be final. |
119
|
| Line is longer than 80 characters. |
124
|
| Method 'findParty' is not designed for extension - needs to be abstract, final or empty. |
126
|
| Parameter id should be final. |
126
|
| Line is longer than 80 characters. |
131
|
| Method 'findPartyWithDetails' is not designed for extension - needs to be abstract, final or empty. |
133
|
| Parameter id should be final. |
133
|
| Line is longer than 80 characters. |
138
|
| Method 'deleteParty' is not designed for extension - needs to be abstract, final or empty. |
140
|
| Parameter id should be final. |
140
|
| Line is longer than 80 characters. |
147
|
| Method 'createContactInfo' is not designed for extension - needs to be abstract, final or empty. |
149
|
| Parameter contactInfo should be final. |
149
|
| Line is longer than 80 characters. |
159
|
| Method 'updateContactInfo' is not designed for extension - needs to be abstract, final or empty. |
161
|
| Parameter contactInfo should be final. |
161
|
| Line is longer than 80 characters. |
166
|
| Method 'findContactInfo' is not designed for extension - needs to be abstract, final or empty. |
169
|
| Parameter contactInfo should be final. |
169
|
| Parameter firstElement should be final. |
170
|
| Parameter maxElements should be final. |
170
|
| Line is longer than 80 characters. |
175
|
| Method 'findContactInfo' is not designed for extension - needs to be abstract, final or empty. |
177
|
| Parameter id should be final. |
177
|
| Line is longer than 80 characters. |
182
|
| Method 'deleteContactInfo' is not designed for extension - needs to be abstract, final or empty. |
184
|
| Parameter id should be final. |
184
|
net/sf/oness/party/model/facade/action/CreatePartyAction.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/facade/action/CreatePartyAction.java
Error | Line |
| Line does not match expected header line of ' * '. |
3
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
34
|
| Line is longer than 80 characters. |
36
|
| Missing a Javadoc comment. |
36
|
| Parameter partyDao should be final. |
36
|
| 'partyDao' hides a field. |
36
|
| Parameter party should be final. |
36
|
| 'party' hides a field. |
36
|
| Parameter ignoreExisting should be final. |
36
|
| 'ignoreExisting' hides a field. |
36
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
42
|
| Missing a Javadoc comment. |
42
|
| 'if' construct must use '{}'s. |
43
|
net/sf/oness/party/model/facade/action/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sf/oness/party/model/facade/package.html
Error | Line |
| Missing package documentation file. | 0 |
net/sf/oness/party/model/party/bo/Organization.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/party/bo/Organization.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| Line has trailing spaces. |
20
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
28
|
| 'static' modifier out of order with the JLS suggestions. |
28
|
| Missing a Javadoc comment. |
30
|
| Line has trailing spaces. |
34
|
| Method 'getOfficialName' is not designed for extension - needs to be abstract, final or empty. |
37
|
| Method 'setOfficialName' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Missing a Javadoc comment. |
41
|
| Parameter officialName should be final. |
41
|
| 'officialName' hides a field. |
41
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
49
|
net/sf/oness/party/model/party/bo/Party.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/party/bo/Party.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| Line has trailing spaces. |
26
|
| Line has trailing spaces. |
28
|
| Line has trailing spaces. |
30
|
| Line has trailing spaces. |
32
|
| Missing a Javadoc comment. |
38
|
| Missing a Javadoc comment. |
40
|
| Missing a Javadoc comment. |
42
|
| Line has trailing spaces. |
46
|
| Method 'getInternalName' is not designed for extension - needs to be abstract, final or empty. |
49
|
| Method 'setInternalName' is not designed for extension - needs to be abstract, final or empty. |
53
|
| Missing a Javadoc comment. |
53
|
| Parameter internalName should be final. |
53
|
| 'internalName' hides a field. |
53
|
| Line has trailing spaces. |
59
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
62
|
| Method 'setContactInfos' is not designed for extension - needs to be abstract, final or empty. |
70
|
| Parameter contactInfos should be final. |
70
|
| 'contactInfos' hides a field. |
70
|
| Line is longer than 80 characters. |
77
|
| Line has trailing spaces. |
78
|
| Method 'getContactInfos' is not designed for extension - needs to be abstract, final or empty. |
81
|
| Method 'addContactInfo' is not designed for extension - needs to be abstract, final or empty. |
85
|
| Missing a Javadoc comment. |
85
|
| Parameter contactInfo should be final. |
85
|
| 'if' construct must use '{}'s. |
86
|
| Method 'setFareId' is not designed for extension - needs to be abstract, final or empty. |
96
|
| Parameter fareId should be final. |
96
|
| 'fareId' hides a field. |
96
|
| Line has trailing spaces. |
102
|
| Method 'getFareId' is not designed for extension - needs to be abstract, final or empty. |
105
|
net/sf/oness/party/model/party/bo/Person.java
Error | Line |
| File does not end with a newline. |
0
|
net/sf/oness/party/model/party/bo/Person.java
Error | Line |
| Line has trailing spaces. |
3
|
| Line has trailing spaces. |
7
|
| Line has trailing spaces. |
9
|
| Line has trailing spaces. |
20
|
| Line has trailing spaces. |
22
|
| Missing a Javadoc comment. |
28
|
| 'static' modifier out of order with the JLS suggestions. |
28
|
| Missing a Javadoc comment. |
30
|
| Missing a Javadoc comment. |
32
|
| Missing a Javadoc comment. |
34
|
| Line has trailing spaces. |
37
|
| Line has trailing spaces. |
38
|
| Method 'getTitle' is not designed for extension - needs to be abstract, final or empty. |
41
|
| Method 'setTitle' is not designed for extension - needs to be abstract, final or empty. |
45
|
| Missing a Javadoc comment. |
45
|
| Parameter title should be final. |
45
|
| 'title' hides a field. |
45
|
| Line has trailing spaces. |
50
|
| Line has trailing spaces. |
51
|
| Method 'getFirstName' is not designed for extension - needs to be abstract, final or empty. |
54
|
| Method 'setFirstName' is not designed for extension - needs to be abstract, final or empty. |
58
|
| Missing a Javadoc comment. |
58
|
| Parameter firstName should be final. |
58
|
| 'firstName' hides a field. |
58
|
| Line has trailing spaces. |
63
|
| Line has trailing spaces. |
64
|
| Method 'getLastName' is not designed for extension - needs to be abstract, final or empty. |
67
|
| Method 'setLastName' is not designed for extension - needs to be abstract, final or empty. |
71
|
| Missing a Javadoc comment. |
71
|
| Parameter lastName should be final. |
71
|
| 'lastName' hides a field. |
71
|
| Method 'getType' is not designed for extension - needs to be abstract, final or empty. |
79
|
net/sf/oness/party/model/party/bo/package.html
Error | Line |
| Missing package documentation file. | 0 |