Checkstyle Results
The following document contains the results of
Checkstyle
.
Summary
| Files | Infos | Warnings | Errors |
|---|
| 36 | 0 | 0 | 264 |
Files
net/sf/oness/common/webapp/controller/action/ActionUtils.java
| Error | Line |
|---|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/action/ActionUtils.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Class ActionUtils should be declared as final. |
31
|
|
| Missing a Javadoc comment. |
33
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| First sentence should end with a period. |
39
|
|
| Line has trailing spaces. |
41
|
|
| Line has trailing spaces. |
44
|
|
| Parameter list should be final. |
52
|
|
| Parameter attributeName should be final. |
53
|
|
| Parameter request should be final. |
54
|
|
| Expected @param tag for 'request'. |
54
|
|
| Line has trailing spaces. |
68
|
|
| Line is longer than 80 characters. |
69
|
|
| Line has trailing spaces. |
70
|
|
| Parameter list should be final. |
75
|
|
| Parameter request should be final. |
76
|
|
| Expected @param tag for 'request'. |
76
|
|
| First sentence should end with a period. |
80
|
|
| Expected an @return tag. |
86
|
|
| Parameter request should be final. |
86
|
|
| Expected @param tag for 'request'. |
86
|
|
| Avoid inline conditionals. |
94
|
|
| First sentence should end with a period. |
98
|
|
| Expected an @return tag. |
104
|
|
| Parameter request should be final. |
104
|
|
| Expected @param tag for 'request'. |
104
|
|
| Avoid inline conditionals. |
107
|
net/sf/oness/common/webapp/controller/action/AutoDispatchAction.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/action/AutoDispatchAction.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
36
|
|
| Missing a Javadoc comment. |
43
|
|
| Missing a Javadoc comment. |
45
|
|
| First sentence should end with a period. |
47
|
|
| Line has trailing spaces. |
49
|
|
| Method 'getBean' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Parameter name should be final. |
54
|
|
| 'if' construct must use '{}'s. |
55
|
|
| Line has trailing spaces. |
62
|
|
| Line has trailing spaces. |
64
|
|
| Method 'getKeyMethodMap' is not designed for extension - needs to be abstract, final or empty. |
67
|
|
| Line has trailing spaces. |
91
|
|
| Line has trailing spaces. |
93
|
|
| Line has trailing spaces. |
98
|
|
| Line has trailing spaces. |
100
|
|
| Line has trailing spaces. |
103
|
|
| Line has trailing spaces. |
105
|
|
| Line has trailing spaces. |
114
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
127
|
|
| Parameter mapping should be final. |
127
|
|
| Parameter form should be final. |
127
|
|
| Parameter request should be final. |
128
|
|
| Parameter response should be final. |
128
|
|
| Avoid inline conditionals. |
141
|
|
| First sentence should end with a period. |
171
|
|
| Line has trailing spaces. |
173
|
|
| Expected an @return tag. |
180
|
|
| Method 'getDynaProperty' is not designed for extension - needs to be abstract, final or empty. |
180
|
|
| Parameter actionForm should be final. |
180
|
|
| Parameter name should be final. |
180
|
net/sf/oness/common/webapp/controller/action/DatabasePopulatorAction.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/action/DatabasePopulatorAction.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
28
|
|
| Line has trailing spaces. |
31
|
|
| Missing a Javadoc comment. |
37
|
|
| Line is longer than 80 characters. |
40
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Parameter actionMapping should be final. |
45
|
|
| Parameter actionForm should be final. |
46
|
|
| Parameter servletRequest should be final. |
46
|
|
| Parameter servletResponse should be final. |
47
|
|
| 'if' construct must use '{}'s. |
48
|
net/sf/oness/common/webapp/controller/action/SpringActionSupport.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/action/SpringActionSupport.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
22
|
|
| Line has trailing spaces. |
24
|
|
| Missing a Javadoc comment. |
30
|
|
| Missing a Javadoc comment. |
32
|
|
| Missing a Javadoc comment. |
34
|
|
| Parameter actionServlet should be final. |
34
|
|
| 'actionServlet' hides a field. |
34
|
|
| First sentence should end with a period. |
38
|
|
| Line has trailing spaces. |
40
|
|
| Method 'getBean' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Parameter name should be final. |
45
|
net/sf/oness/common/webapp/controller/action/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/webapp/controller/listener/SpringContextLoaderListener.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/listener/SpringContextLoaderListener.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
32
|
|
| Missing a Javadoc comment. |
38
|
|
| Method 'contextInitialized' is not designed for extension - needs to be abstract, final or empty. |
41
|
|
| Missing a Javadoc comment. |
41
|
|
| Parameter event should be final. |
41
|
|
| Line has trailing spaces. |
79
|
|
| Method 'initialize' is not designed for extension - needs to be abstract, final or empty. |
82
|
|
| Parameter applicationContext should be final. |
82
|
|
| Expected @param tag for 'applicationContext'. |
82
|
|
| Parameter servletContext should be final. |
83
|
|
| Expected @param tag for 'servletContext'. |
83
|
|
| Expected @throws tag for 'Exception'. |
83
|
|
| Line is longer than 80 characters. |
84
|
|
| 'if' construct must use '{}'s. |
86
|
net/sf/oness/common/webapp/controller/listener/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/webapp/controller/struts/ActionServlet.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/struts/ActionServlet.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
27
|
|
| Line has trailing spaces. |
29
|
|
| Line has trailing spaces. |
31
|
|
| Line has trailing spaces. |
44
|
|
| Line has trailing spaces. |
50
|
|
| Method 'initModuleMessageResources' is not designed for extension - needs to be abstract, final or empty. |
56
|
|
| Parameter config should be final. |
56
|
|
| Line is longer than 80 characters. |
77
|
|
| Line is longer than 80 characters. |
104
|
net/sf/oness/common/webapp/controller/struts/CustomMessageResources.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/struts/CustomMessageResources.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
36
|
|
| Line is longer than 80 characters. |
39
|
|
| Line has trailing spaces. |
41
|
|
| Line has trailing spaces. |
43
|
|
| First sentence should end with a period. |
49
|
|
| Variable 'bundlesLoaded' must be private and have accessor methods. |
53
|
|
| First sentence should end with a period. |
55
|
|
| Variable 'resourceMap' must be private and have accessor methods. |
56
|
|
| First sentence should end with a period. |
58
|
|
| Variable 'bundles' must be private and have accessor methods. |
59
|
|
| Line has trailing spaces. |
63
|
|
| Parameter configFiles should be final. |
67
|
|
| Method 'getMessage' is not designed for extension - needs to be abstract, final or empty. |
76
|
|
| Parameter locale should be final. |
76
|
|
| Parameter key should be final. |
76
|
|
| Line has trailing spaces. |
106
|
|
| Method 'loadBundle' is not designed for extension - needs to be abstract, final or empty. |
112
|
|
| Parameter localeKey should be final. |
112
|
|
| Parameter config should be final. |
112
|
|
| Line is longer than 80 characters. |
125
|
net/sf/oness/common/webapp/controller/struts/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/webapp/controller/testing/JMockStrutsTestCase.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/testing/JMockStrutsTestCase.java
| Error | Line |
|---|
|
| Line has trailing spaces. |
3
|
|
| Line has trailing spaces. |
7
|
|
| Line has trailing spaces. |
9
|
|
| Line has trailing spaces. |
37
|
|
| Line has trailing spaces. |
42
|
|
| Line has trailing spaces. |
47
|
|
| Line has trailing spaces. |
49
|
|
| Missing a Javadoc comment. |
55
|
|
| Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
55
|
|
| Line is longer than 80 characters. |
57
|
|
| Missing a Javadoc comment. |
57
|
|
| Line is longer than 80 characters. |
59
|
|
| Missing a Javadoc comment. |
59
|
|
| Missing a Javadoc comment. |
61
|
|
| Name 'contextDirectory' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
61
|
|
| Missing a Javadoc comment. |
64
|
|
| Missing a Javadoc comment. |
66
|
|
| Missing a Javadoc comment. |
68
|
|
| Missing a Javadoc comment. |
73
|
|
| Parameter name should be final. |
73
|
|
| Method 'setUp' is not designed for extension - needs to be abstract, final or empty. |
81
|
|
| Line is longer than 80 characters. |
86
|
|
| Line is longer than 80 characters. |
98
|
|
| First sentence should end with a period. |
105
|
|
| Line has trailing spaces. |
107
|
|
| Expected an @return tag. |
110
|
|
| Method 'getApplicationContext' is not designed for extension - needs to be abstract, final or empty. |
110
|
|
| First sentence should end with a period. |
116
|
|
| Line has trailing spaces. |
118
|
|
| Expected an @return tag. |
121
|
|
| Method 'getMockWebApplicationContext' is not designed for extension - needs to be abstract, final or empty. |
121
|
|
| First sentence should end with a period. |
125
|
|
| Line has trailing spaces. |
128
|
|
| Method 'struts' is not designed for extension - needs to be abstract, final or empty. |
131
|
net/sf/oness/common/webapp/controller/testing/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/webapp/controller/tiles/SwitchLayoutController.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/tiles/SwitchLayoutController.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
50
|
|
| Line has trailing spaces. |
52
|
|
| Line is longer than 80 characters. |
56
|
|
| Missing a Javadoc comment. |
58
|
|
| Line is longer than 80 characters. |
66
|
|
| Method 'execute' is not designed for extension - needs to be abstract, final or empty. |
71
|
|
| Parameter tileContext should be final. |
71
|
|
| Parameter request should be final. |
72
|
|
| Parameter response should be final. |
72
|
|
| Parameter servletContext should be final. |
73
|
|
| 'if' construct must use '{}'s. |
76
|
net/sf/oness/common/webapp/controller/tiles/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
net/sf/oness/common/webapp/controller/util/AuditableToStringConverter.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/util/AuditableToStringConverter.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
26
|
|
| Line has trailing spaces. |
28
|
|
| Missing a Javadoc comment. |
34
|
|
| Missing a Javadoc comment. |
36
|
|
| Method 'convert' is not designed for extension - needs to be abstract, final or empty. |
45
|
|
| Parameter type should be final. |
45
|
|
| Expected @param tag for 'type'. |
45
|
|
| Parameter value should be final. |
45
|
|
| Expected @param tag for 'value'. |
45
|
net/sf/oness/common/webapp/controller/util/ConvertUtils.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/util/ConvertUtils.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| First sentence should end with a period. |
29
|
|
| Line has trailing spaces. |
32
|
|
| Expected an @return tag. |
36
|
|
| Parameter array should be final. |
36
|
|
| Expected @param tag for 'array'. |
36
|
net/sf/oness/common/webapp/controller/util/NonEmptyStringConverter.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/util/NonEmptyStringConverter.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
24
|
|
| Missing a Javadoc comment. |
30
|
|
| '{' is followed by whitespace. |
30
|
|
| Missing a Javadoc comment. |
33
|
|
| First sentence should end with a period. |
35
|
|
| Line is longer than 80 characters. |
58
|
|
| Line has trailing spaces. |
65
|
|
| Parameter converter should be final. |
69
|
|
| 'converter' hides a field. |
69
|
|
| Line has trailing spaces. |
76
|
|
| Method 'convert' is not designed for extension - needs to be abstract, final or empty. |
80
|
|
| Parameter type should be final. |
80
|
|
| Parameter value should be final. |
80
|
|
| 'if' construct must use '{}'s. |
83
|
net/sf/oness/common/webapp/controller/util/StringArrayToAuditableConverter.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/util/StringArrayToAuditableConverter.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
28
|
|
| Line has trailing spaces. |
30
|
|
| Missing a Javadoc comment. |
36
|
|
| Line has trailing spaces. |
39
|
|
| Parameter auditableValue should be final. |
43
|
|
| 'auditableValue' hides a field. |
43
|
|
| Method 'convert' is not designed for extension - needs to be abstract, final or empty. |
54
|
|
| Parameter type should be final. |
54
|
|
| Expected @param tag for 'type'. |
54
|
|
| Parameter value should be final. |
54
|
|
| Expected @param tag for 'value'. |
54
|
|
| Array brackets at illegal position. |
55
|
|
| 'if' construct must use '{}'s. |
56
|
net/sf/oness/common/webapp/controller/util/StringArrayToSetConverter.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/util/StringArrayToSetConverter.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
26
|
|
| Line has trailing spaces. |
28
|
|
| Method 'convert' is not designed for extension - needs to be abstract, final or empty. |
39
|
|
| Parameter type should be final. |
39
|
|
| Expected @param tag for 'type'. |
39
|
|
| Parameter value should be final. |
39
|
|
| Expected @param tag for 'value'. |
39
|
net/sf/oness/common/webapp/controller/util/StringToAuditableConverter.java
| Error | Line |
|---|
|
| File does not end with a newline. |
0
|
net/sf/oness/common/webapp/controller/util/StringToAuditableConverter.java
| Error | Line |
|---|
|
| Line does not match expected header line of ' * '. |
3
|
|
| Line has trailing spaces. |
25
|
|
| Line has trailing spaces. |
27
|
|
| Missing a Javadoc comment. |
33
|
|
| Line has trailing spaces. |
36
|
|
| Parameter auditableValue should be final. |
40
|
|
| 'auditableValue' hides a field. |
40
|
|
| Method 'convert' is not designed for extension - needs to be abstract, final or empty. |
51
|
|
| Parameter type should be final. |
51
|
|
| Expected @param tag for 'type'. |
51
|
|
| Parameter value should be final. |
51
|
|
| Expected @param tag for 'value'. |
51
|
net/sf/oness/common/webapp/controller/util/package.html
| Error | Line |
|---|
|
| Missing package documentation file. | 0 |
